[LCG] Don't skip invalidation of LazyCallGraph if CFG analyses are preserved

[aeubanks]

Summary

The CFG being changed and the overall call graph are not related, we can introduce/remove calls without changing the CFG.

Resolves one of the issues in PR51946.

[aeubanks]

-disable-output

[aeubanks]

simplify test

[asbirlea]

LGTM.

llvm/lib/Analysis/LazyCallGraph.cpp

LazyCallGraph::LazyCallGraph(LazyCallGraph &&G)
   updateGraphPtrs();
 }
 
 bool LazyCallGraph::invalidate(Module &, const PreservedAnalyses &PA,
                                ModuleAnalysisManager::Invalidator &) {
   // Check whether the analysis, all analyses on functions, or the function's
   // CFG have been preserved.
   auto PAC = PA.getChecker<llvm::LazyCallGraphAnalysis>();
-  return !(PAC.preserved() || PAC.preservedSet<AllAnalysesOn<Module>>() ||
-           PAC.preservedSet<CFGAnalyses>());
+  return !(PAC.preserved() || PAC.preservedSet<AllAnalysesOn<Module>>());
 }
 
 LazyCallGraph &LazyCallGraph::operator=(LazyCallGraph &&G) {
   BPA = std::move(G.BPA);
   NodeMap = std::move(G.NodeMap);
   EntryEdges = std::move(G.EntryEdges);
   SCCBPA = std::move(G.SCCBPA);
   SCCMap = std::move(G.SCCMap);

llvm/test/Analysis/LazyCallGraph/invalidate.ll

+; REQUIRES: x86-registered-target
+; RUN: opt -passes='cgscc(no-op-cgscc),function(slp-vectorizer),cgscc(function(sroa))' -debug-pass-manager -disable-output < %s 2>&1 | FileCheck %s
+
+; CHECK: Invalidating {{.*}} LazyCallGraph
+
+target triple = "x86_64-unknown-linux-gnu"
+
+define i16 @my_lookup() {
+entry:
+  %lbl_addrs = alloca [3 x i8*], align 1
+  store i8* blockaddress(@my_lookup, %lbl2), i8** undef, align 1
+  %arrayinit.element1 = getelementptr inbounds i8*, i8** undef, i32 1
+  store i8* blockaddress(@my_lookup, %lbl3), i8** %arrayinit.element1, align 1
+  callbr void asm sideeffect "bra $0", "a,X,X,X"(i8* undef, i8* blockaddress(@my_lookup, %lbl1), i8* blockaddress(@my_lookup, %lbl2), i8* blockaddress(@my_lookup, %lbl3))
+          to label %asm.fallthrough [label %lbl1, label %lbl2, label %lbl3]
+
+asm.fallthrough:                                  ; preds = %entry
+  unreachable
+
+lbl1:                                             ; preds = %entry
+  ret i16 undef
+
+lbl2:                                             ; preds = %entry
+  unreachable
+
+lbl3:                                             ; preds = %entry
+  unreachable
+}
+
+define void @idi() {
+entry:
+  ret void
+}