This is an archive of the discontinued LLVM Phabricator instance.

[NFC][sanitizer] Remove global PersistentAllocator
ClosedPublic

Authored by vitalybuka on Oct 6 2021, 12:39 PM.

Details

Summary

This way is easier to track memory usage and do other
incremental refactorings.

Diff Detail

Event Timeline

vitalybuka created this revision.Oct 6 2021, 12:39 PM
vitalybuka requested review of this revision.Oct 6 2021, 12:39 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptOct 6 2021, 12:39 PM
Herald added subscribers: llvm-commits, Restricted Project, cfe-commits. · View Herald Transcript

update a test

morehouse added inline comments.Oct 6 2021, 2:32 PM
compiler-rt/lib/sanitizer_common/sanitizer_persistent_allocator.h
61

This changes the meaning of stats.allocated to "mmapped memory" instead of "returned memory"

64

duplicate line.

vitalybuka updated this revision to Diff 377711.Oct 6 2021, 3:24 PM

remove duplicate

vitalybuka updated this revision to Diff 377714.Oct 6 2021, 3:45 PM

fixed size

vitalybuka marked an inline comment as done.Oct 6 2021, 3:46 PM
vitalybuka added inline comments.
compiler-rt/lib/sanitizer_common/sanitizer_persistent_allocator.h
61

Probably not important but easy to fix.

This revision is now accepted and ready to land.Oct 7 2021, 7:11 AM
vitalybuka marked an inline comment as done.

rebase

This revision was landed with ongoing or failed builds.Oct 7 2021, 1:54 PM
This revision was automatically updated to reflect the committed changes.
compiler-rt/lib/sanitizer_common/sanitizer_persistent_allocator.h