This is an archive of the discontinued LLVM Phabricator instance.

Differential D111251

[mlir] Fix redundant return in the void method.
ClosedPublic

Authored by rdzhabarov on Oct 6 2021, 11:27 AM.

Details

Reviewers
antiagainst
jpienaar
Commits
rGfb3d83acaf1c: [mlir] Fix redundant return in the void method.
Summary

clang-tidy, fix redundant return statement at the end of the void method.

Diff Detail

Event Timeline

rdzhabarov created this revision.Oct 6 2021, 11:27 AM
Herald added a reviewer: antiagainst. · View Herald TranscriptOct 6 2021, 11:27 AM
Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan and 18 others. · View Herald Transcript
rdzhabarov requested review of this revision.Oct 6 2021, 11:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 6 2021, 11:27 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
jpienaar accepted this revision.Oct 6 2021, 11:34 AM
This revision is now accepted and ready to land.Oct 6 2021, 11:34 AM
This revision was landed with ongoing or failed builds.Oct 6 2021, 11:45 AM
Closed by commit rGfb3d83acaf1c: [mlir] Fix redundant return in the void method. (authored by rdzhabarov). · Explain Why
This revision was automatically updated to reflect the committed changes.
rdzhabarov added a commit: rGfb3d83acaf1c: [mlir] Fix redundant return in the void method..
Harbormaster completed remote builds in B127348: Diff 377619.Oct 6 2021, 12:01 PM

Revision Contents

PathSize
mlir/
lib/
TableGen/
1 line

Diff 377625

mlir/lib/TableGen/Pattern.cpp

Show First 20 Lines • Show All 814 Lines • ▼ Show 20 Linesvoid Pattern::collectBoundSymbols(DagNode tree, SymbolInfoMap &infoMap,
} }
if (!treeName.empty()) { if (!treeName.empty()) {
PrintFatalError( PrintFatalError(
&def, formatv("binding symbol '{0}' to non-operation/native code call " &def, formatv("binding symbol '{0}' to non-operation/native code call "
"unsupported right now", "unsupported right now",
treeName)); treeName));
} }
return;
} }