This is an archive of the discontinued LLVM Phabricator instance.

[mlir][tosa] Create basic dynamic shape support for several ops.
ClosedPublic

Authored by NatashaKnk on Oct 5 2021, 9:20 AM.

Details

Summary

Transpose, Matmul and Fully-connected dynamic shape support

Diff Detail

Event Timeline

NatashaKnk created this revision.Oct 5 2021, 9:20 AM
NatashaKnk requested review of this revision.Oct 5 2021, 9:20 AM
rsuderman requested changes to this revision.Oct 5 2021, 11:10 AM
rsuderman added inline comments.
mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
1370

You need to include checks that firstOperandTy.hasRank(). Otherwise this may fail. (See other cases below).

This revision now requires changes to proceed.Oct 5 2021, 11:10 AM
rsuderman added inline comments.Oct 5 2021, 11:12 AM
mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
1370

Not, that it should be an "or" case. This is because isDynamicDim will fail if the rank isn't known but we would still want the DimOp

NatashaKnk updated this revision to Diff 377334.Oct 5 2021, 1:14 PM

Add checks for unranked tensors

rsuderman accepted this revision.Oct 5 2021, 2:24 PM
This revision is now accepted and ready to land.Oct 5 2021, 2:24 PM