ArgsABI was originally added in https://reviews.llvm.org/D965
Current benchmarking does not show a significant difference.
There is no need to maintain both ABIs.
Paths
| Differential D111097
[DFSan] Remove -dfsan-args-abi support in favor of TLS. ClosedPublic Authored by browneee on Oct 4 2021, 1:33 PM.
Details Summary ArgsABI was originally added in https://reviews.llvm.org/D965 Current benchmarking does not show a significant difference.
Diff Detail
Unit TestsFailed
Event TimelineHerald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 4 2021, 1:33 PM Comment Actions LGTM
This revision is now accepted and ready to land.Oct 8 2021, 10:53 AM This revision was landed with ongoing or failed builds.Oct 8 2021, 11:19 AM Closed by commit rG61ec2148c5a6: [DFSan] Remove -dfsan-args-abi support in favor of TLS. (authored by browneee). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 377059 compiler-rt/test/dfsan/basic.c
compiler-rt/test/dfsan/custom.cpp
compiler-rt/test/dfsan/fncall.c
compiler-rt/test/dfsan/propagate.c
compiler-rt/test/dfsan/vararg.c
compiler-rt/test/dfsan/write_callback.c
llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
llvm/test/Instrumentation/DataFlowSanitizer/abilist.ll
llvm/test/Instrumentation/DataFlowSanitizer/abilist_aggregate.ll
llvm/test/Instrumentation/DataFlowSanitizer/args-unreachable-bb.ll
llvm/test/Instrumentation/DataFlowSanitizer/array.ll
llvm/test/Instrumentation/DataFlowSanitizer/custom_fun_callback_attributes.ll
llvm/test/Instrumentation/DataFlowSanitizer/custom_fun_varargs_attributes.ll
llvm/test/Instrumentation/DataFlowSanitizer/debug-nonzero-labels.ll
llvm/test/Instrumentation/DataFlowSanitizer/memset.ll
llvm/test/Instrumentation/DataFlowSanitizer/prefix-rename.ll
llvm/test/Instrumentation/DataFlowSanitizer/struct.ll
llvm/test/Instrumentation/DataFlowSanitizer/uninstrumented_local_functions.ll
llvm/test/Instrumentation/DataFlowSanitizer/unordered_atomic_mem_intrins.ll
llvm/test/Instrumentation/DataFlowSanitizer/vector.ll
|
Remove this line and use FT below.