This is an archive of the discontinued LLVM Phabricator instance.

[DFSan] Remove -dfsan-args-abi support in favor of TLS.
ClosedPublic

Authored by browneee on Oct 4 2021, 1:33 PM.

Details

Summary

ArgsABI was originally added in https://reviews.llvm.org/D965

Current benchmarking does not show a significant difference.
There is no need to maintain both ABIs.

Diff Detail

Event Timeline

browneee created this revision.Oct 4 2021, 1:33 PM
browneee requested review of this revision.Oct 4 2021, 1:33 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 4 2021, 1:33 PM
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
browneee updated this revision to Diff 377049.Oct 4 2021, 4:08 PM

Fix build.

pcc accepted this revision.Oct 8 2021, 10:53 AM

LGTM

llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
1429–1430

Remove this line and use FT below.

This revision is now accepted and ready to land.Oct 8 2021, 10:53 AM
browneee updated this revision to Diff 378311.Oct 8 2021, 11:01 AM
browneee marked an inline comment as done.

Fix unnecessary variable.

This revision was landed with ongoing or failed builds.Oct 8 2021, 11:19 AM
This revision was automatically updated to reflect the committed changes.