This is an archive of the discontinued LLVM Phabricator instance.

[mlir][linalg] Retire PoolingMaxOp/PoolingMinOp/PoolingSumOp.
ClosedPublic

Authored by gysit on Oct 1 2021, 1:20 AM.

Details

Summary

The pooling ops are among the last remaining hard coded Linalg operations that have no region attached. They got obsolete due to the OpDSL pooling operations. Removing them allows us to delete specialized code and tests that are not needed for the OpDSL counterparts that rely on the standard code paths.

Event Timeline

gysit created this revision.Oct 1 2021, 1:20 AM
gysit requested review of this revision.Oct 1 2021, 1:20 AM
gysit edited the summary of this revision. (Show Details)Oct 1 2021, 1:22 AM
gysit updated this revision to Diff 376451.Oct 1 2021, 1:54 AM

Additionally remove hasPadding specialization for the pooling ops.

nicolasvasilache accepted this revision.Oct 1 2021, 6:01 AM

Awesome, thank you @gysit !

This revision is now accepted and ready to land.Oct 1 2021, 6:01 AM
gysit updated this revision to Diff 376503.Oct 1 2021, 6:28 AM

Rebase.