This is an archive of the discontinued LLVM Phabricator instance.

Differential D110889

[clang][Fuchsia] Add -DSCUDO_DISABLE_TBI to test flags
AbandonedPublic

Authored by leonardchan on Sep 30 2021, 3:33 PM.

Details

Reviewers
phosek
Summary

After D110888, this will ensure that MTE tests are skipped when running scudo tests on aarch64.

Diff Detail

Event Timeline

leonardchan created this revision.Sep 30 2021, 3:33 PM
Herald added subscribers: cryptoad, kristof.beyls, mgorny. · View Herald TranscriptSep 30 2021, 3:33 PM
leonardchan requested review of this revision.Sep 30 2021, 3:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2021, 3:33 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
phosek added a comment.Sep 30 2021, 11:28 PM

Is this needed even with D110888?

leonardchan abandoned this revision.Oct 4 2021, 1:17 PM
In D110889#3035597, @phosek wrote:

Is this needed even with D110888?

Nope, at least after the updated patch this isn't needed anymore. Abandoning.

Herald added a subscriber: abrachet. · View Herald TranscriptOct 4 2021, 1:17 PM

Revision Contents

PathSize
clang/
cmake/
caches/
2 lines

Diff 376387

clang/cmake/caches/Fuchsia-stage2.cmake

Context not available.
set(RUNTIMES_${target}_LLVM_ENABLE_ASSERTIONS OFF CACHE BOOL "") set(RUNTIMES_${target}_LLVM_ENABLE_ASSERTIONS OFF CACHE BOOL "")
set(RUNTIMES_${target}_SANITIZER_CXX_ABI "libc++" CACHE STRING "") set(RUNTIMES_${target}_SANITIZER_CXX_ABI "libc++" CACHE STRING "")
set(RUNTIMES_${target}_SANITIZER_CXX_ABI_INTREE ON CACHE BOOL "") set(RUNTIMES_${target}_SANITIZER_CXX_ABI_INTREE ON CACHE BOOL "")
set(RUNTIMES_${target}_COMPILER_RT_TEST_COMPILER_CFLAGS "--unwindlib=libunwind -static-libgcc" CACHE STRING "") set(RUNTIMES_${target}_COMPILER_RT_TEST_COMPILER_CFLAGS "--unwindlib=libunwind -static-libgcc -DSCUDO_DISABLE_TBI" CACHE STRING "")
set(RUNTIMES_${target}_SANITIZER_COMMON_TEST_TARGET_CFLAGS "--unwindlib=libunwind -static-libgcc" CACHE STRING "") set(RUNTIMES_${target}_SANITIZER_COMMON_TEST_TARGET_CFLAGS "--unwindlib=libunwind -static-libgcc" CACHE STRING "")
set(RUNTIMES_${target}_TSAN_TEST_TARGET_CFLAGS "--unwindlib=libunwind" CACHE STRING "") set(RUNTIMES_${target}_TSAN_TEST_TARGET_CFLAGS "--unwindlib=libunwind" CACHE STRING "")
set(RUNTIMES_${target}_LLVM_TOOLS_DIR "${CMAKE_BINARY_DIR}/bin" CACHE BOOL "") set(RUNTIMES_${target}_LLVM_TOOLS_DIR "${CMAKE_BINARY_DIR}/bin" CACHE BOOL "")
Context not available.