Add Windows ARM targets for mingw and cygwin to clang

[martell]

Summary

Add support for armv7-windows-gnu targets to the clang front end.

Relative LLVM review

http://reviews.llvm.org/D11075

Windows only supports Little endian so it made more sense to have the naming reflect this.
It was confusing looking through the source to see that darwin arm targets did not specify endianess because they only support one yet we were specifying for itanium arm on windows.
I fixed that in the patch also

[martell]

Updated with full file context as requested by Yaron

[martell]

Tidied up the patch to make it more readable

[rnk]

lgtm

[yaron.keren]

This does not compile against SVN. Please update and run tests.

C:\llvm-clean\tools\clang\lib\Basic\Targets.cpp(4961): error C2011: '`anonymous-namespace'::MinGWARMTargetInfo' : 'class'

type redefinition [C:\llvm-clean\msvc\tools\clang\lib\Basic\clangBasic.vcxproj]

C:\llvm-clean\tools\clang\lib\Basic\Targets.cpp(4979): error C2011: '`anonymous-namespace'::CygwinARMTargetInfo' : 'class'  type redefinition [C:\llvm-clean\msvc\tools\clang\lib\Basic\clangBasic.vcxproj]
C:\llvm-clean\tools\clang\lib\Basic\Targets.cpp(7121): error C2027: use of undefined type '`anonymous-namespace'::CygwinAR MTargetInfo' [C:\llvm-clean\msvc\tools\clang\lib\Basic\clangBasic.vcxproj]
C:\llvm-clean\tools\clang\lib\Basic\Targets.cpp(7123): error C2027: use of undefined type '`anonymous-namespace'::MinGWARM TargetInfo' [C:\llvm-clean\msvc\tools\clang\lib\Basic\clangBasic.vcxproj]

[yaron.keren]

Also, please base the diff from top-level llvm directory not from clang subdir, so that the diff starts with:

Index: tools/clang/lib/Basic/Targets.cpp

• tools/clang/lib/Basic/Targets.cpp

+++ tools/clang/lib/Basic/Targets.cpp

[martell]

compnerd requested that we leave the le postfix for itanium targets
added back in the blank namespace guard to fix compile errors

Yaron I previously had namespace guards around the 2 targets.
Removing these in the latest patch caused the compile failure
It seems all mingw targets have a separate guard like this.

If someone could explain why this is needed it would be great :)

[martell]

2nd attempt to set it to tools/clang/

[yaron.keren]

I merged the anonymous namespaces to the existing one, r242292.

lib/Basic/Targets.cpp

   }
 };
 
+// Windows ARM, MS (C++) ABI
+class MicrosoftARMTargetInfo : public WindowsARMTargetInfo {
+public:
+  MicrosoftARMTargetInfo(const llvm::Triple &Triple)
+    : WindowsARMTargetInfo(Triple) {
+    TheCXXABI.set(TargetCXXABI::Microsoft);
+  }
+
+  void getTargetDefines(const LangOptions &Opts,
+                        MacroBuilder &Builder) const override {
+    WindowsARMTargetInfo::getTargetDefines(Opts, Builder);
+    WindowsARMTargetInfo::getVisualStudioDefines(Opts, Builder);
+  }
+};
+} // end anonymous namespace.
+
+namespace {
+// ARM MinGW target
+class MinGWARMTargetInfo : public WindowsARMTargetInfo {
+public:
+  MinGWARMTargetInfo(const llvm::Triple &Triple)
+    : WindowsARMTargetInfo(Triple) {
+    TheCXXABI.set(TargetCXXABI::GenericARM);
+  }
+
+  void getTargetDefines(const LangOptions &Opts,
+                        MacroBuilder &Builder) const override {
+    WindowsARMTargetInfo::getTargetDefines(Opts, Builder);
+    DefineStd(Builder, "WIN32", Opts);
+    DefineStd(Builder, "WINNT", Opts);
+    Builder.defineMacro("_ARM_");
+    addMinGWDefines(Opts, Builder);
+  }
+};
+} // end anonymous namespace
+
+namespace {
+// ARM Cygwin target
+class CygwinARMTargetInfo : public ARMleTargetInfo {
+public:
+  CygwinARMTargetInfo(const llvm::Triple &Triple)
+      : ARMleTargetInfo(Triple) {
+    TLSSupported = false;
+    WCharType = UnsignedShort;
+    DoubleAlign = LongLongAlign = 64;
+    DescriptionString = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64";
+  }
+  void getTargetDefines(const LangOptions &Opts,
+                        MacroBuilder &Builder) const override {
+    ARMleTargetInfo::getTargetDefines(Opts, Builder);
+    Builder.defineMacro("_ARM_");
+    Builder.defineMacro("__CYGWIN__");
+    Builder.defineMacro("__CYGWIN32__");
+    DefineStd(Builder, "unix", Opts);
+    if (Opts.CPlusPlus)
+      Builder.defineMacro("_GNU_SOURCE");
+  }
+};
+} // end anonymous namespace
+
+namespace {
 // Windows ARM + Itanium C++ ABI Target
-class ItaniumWindowsARMleTargetInfo : public WindowsARMTargetInfo {
+class ItaniumWindowsARMTargetInfo : public WindowsARMTargetInfo {
 public:
-  ItaniumWindowsARMleTargetInfo(const llvm::Triple &Triple)
+  ItaniumWindowsARMTargetInfo(const llvm::Triple &Triple)
     : WindowsARMTargetInfo(Triple) {
     TheCXXABI.set(TargetCXXABI::GenericARM);
   }

       switch (Triple.getEnvironment()) {
       default:
         return new ARMleTargetInfo(Triple);
+      case llvm::Triple::Cygnus:
+        return new CygwinARMTargetInfo(Triple);
+      case llvm::Triple::GNU:
+        return new MinGWARMTargetInfo(Triple);
       case llvm::Triple::Itanium:
-        return new ItaniumWindowsARMleTargetInfo(Triple);
+        return new ItaniumWindowsARMTargetInfo(Triple);
       case llvm::Triple::MSVC:
-        return new MicrosoftARMleTargetInfo(Triple);
+        return new MicrosoftARMTargetInfo(Triple);
       }
     default:
       return new ARMleTargetInfo(Triple);