This is an archive of the discontinued LLVM Phabricator instance.

[zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot
AbandonedPublic

Authored by saghir on Sep 27 2021, 7:44 PM.

Details

Reviewers
nemanjai
gkistanova
Conanap
lei
jsji
amyk
Group Reviewers
Restricted Project
Summary

Libc++ requires a C++20 capable compiler. However, the current version of gcc build compiler does not support that. This change updates the version of the gcc build compiler to 11.2.0 to fix errors in building libc++.

Diff Detail

Event Timeline

saghir created this revision.Sep 27 2021, 7:44 PM
saghir requested review of this revision.Sep 27 2021, 7:44 PM
saghir retitled this revision from [zorg] [PowerPC] Enable a runtimes build for ppc64be-sanitizer bot to [zorg] [PowerPC] Enable a runtimes build for sanitizer-ppc64be-linux bot.Sep 27 2021, 7:47 PM
nemanjai added inline comments.Sep 28 2021, 5:42 AM
buildbot/osuosl/master/config/builders.py
1402

Some bots use enable_runtimes. What is the difference between doing it that way and this way. It seems to me that if we do it this way, it is just an opaque string to the bot and may not do something that enable_runtimes does.

saghir updated this revision to Diff 377542.Oct 6 2021, 7:30 AM
saghir retitled this revision from [zorg] [PowerPC] Enable a runtimes build for sanitizer-ppc64be-linux bot to [zorg] [PowerPC] Update version of gcc build compiler to 11.2.0 for sanitizer-ppc64be-linux bot.
saghir edited the summary of this revision. (Show Details)

Updates version of gcc build compiler.

saghir added inline comments.Oct 6 2021, 7:32 AM
buildbot/osuosl/master/config/builders.py
1402

Since enable the runtime did not work as expected, I have resorted to updating the version of the gcc build compiler to fix the errors in building libc++.

saghir edited the summary of this revision. (Show Details)Oct 6 2021, 7:46 AM
Conanap accepted this revision.Oct 7 2021, 8:40 AM

lgtm

This revision is now accepted and ready to land.Oct 7 2021, 8:40 AM
amyk accepted this revision.Oct 7 2021, 8:49 AM
amyk added a subscriber: amyk.

I think this LGTM. Thanks for updating this.

It does not look right to have absolute paths for a particular worker specified for a build configuration.

I’d there a way to have it either configured locally on that worker? Or more generic way to specify a version of the system toolchain to use?

saghir abandoned this revision.Oct 12 2021, 6:57 AM

Abandoning this since Galina suggested to do the changes locally for the buildbot.