This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [unittests] Fix building the FreeBSD arm64 Register Context test
ClosedPublic

Authored by andrew on Sep 27 2021, 6:02 AM.

Diff Detail

Event Timeline

andrew created this revision.Sep 27 2021, 6:02 AM
andrew requested review of this revision.Sep 27 2021, 6:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2021, 6:02 AM
mgorny added inline comments.Sep 27 2021, 7:03 AM
lldb/unittests/Process/Utility/RegisterContextFreeBSDTest.cpp
328

Maybe set it to eRegsetMaskDefault explicitly?

andrew updated this revision to Diff 375293.Sep 27 2021, 8:49 AM

Set opt_regsets to eRegsetMaskDefault

mgorny accepted this revision.Sep 27 2021, 8:59 AM

LGTM now, thanks. I don't have an arm64 cross env handy at the time, so I'm assuming you've tested it.

This revision is now accepted and ready to land.Sep 27 2021, 8:59 AM

Yes, I found it by trying to build the tests on FreeBSD/arm64