This is an archive of the discontinued LLVM Phabricator instance.

Differential D110377

compiler-rt: Fix arch detection for ppc64le
ClosedPublic

Authored by tstellar on Sep 23 2021, 6:19 PM.

Details

Reviewers
daltenty
MaskRay
Commits
rG05c21f54a454: compiler-rt: Fix arch detection for ppc64le

Diff Detail

Unit TestsFailed

TimeTest
460 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-cxa-atexit.S
590 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-static-initializer.S
460 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-tls.S

Event Timeline

tstellar created this revision.Sep 23 2021, 6:19 PM
Herald added subscribers: shchenz, mgorny, dberris. · View Herald TranscriptSep 23 2021, 6:19 PM
tstellar requested review of this revision.Sep 23 2021, 6:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2021, 6:19 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
tstellar added a child revision: D109837: cmake: Remove config.guess.Sep 23 2021, 6:24 PM
tstellar added a reviewer: daltenty.
Harbormaster completed remote builds in B125462: Diff 374705.Sep 23 2021, 6:39 PM
MaskRay accepted this revision.Sep 23 2021, 8:21 PM
MaskRay added a subscriber: MaskRay.

LGTM.

This revision is now accepted and ready to land.Sep 23 2021, 8:21 PM
This revision was landed with ongoing or failed builds.Oct 21 2021, 4:12 PM
Closed by commit rG05c21f54a454: compiler-rt: Fix arch detection for ppc64le (authored by tstellar). · Explain Why
This revision was automatically updated to reflect the committed changes.
tstellar added a commit: rG05c21f54a454: compiler-rt: Fix arch detection for ppc64le.

Revision Contents

PathSize
compiler-rt/
cmake/
2 lines

Diff 374705

compiler-rt/cmake/base-config-ix.cmake

Show First 20 Lines • Show All 204 Lines • ▼ Show 20 Lines elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "i[2-6]86|x86|amd64")
test_target_arch(i386 __i386__ "-m32") test_target_arch(i386 __i386__ "-m32")
else() else()
if (CMAKE_SIZEOF_VOID_P EQUAL 4) if (CMAKE_SIZEOF_VOID_P EQUAL 4)
test_target_arch(i386 "" "") test_target_arch(i386 "" "")
else() else()
test_target_arch(x86_64 "" "") test_target_arch(x86_64 "" "")
endif() endif()
endif() endif()
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "powerpc64le") elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "powerpc64le|ppc64le")
test_target_arch(powerpc64le "" "-m64") test_target_arch(powerpc64le "" "-m64")
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "powerpc") elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "powerpc")
if(CMAKE_SYSTEM_NAME MATCHES "AIX") if(CMAKE_SYSTEM_NAME MATCHES "AIX")
test_target_arch(powerpc "" "-m32") test_target_arch(powerpc "" "-m32")
endif() endif()
test_target_arch(powerpc64 "" "-m64") test_target_arch(powerpc64 "" "-m64")
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "s390x") elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "s390x")
test_target_arch(s390x "" "") test_target_arch(s390x "" "")
Show All 40 Lines