[ORC] Minor renaming and typo fixes (NFC)

[sgraenitz]

Summary

One typo, one unsused include and some leftovers from the TargetProcessControl -> ExecutorProcessControl renaming

[xgupta]

Although this patch is correct, running ./LLJITWithTargetProcessControl result in segmentation fault.

PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace.
Stack dump:
0. Program arguments: ./LLJITWithTargetProcessControl
#0 0x00007fdee365ab73 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/xgupta/llvm/llvm-upstream/build/bin/../lib/libLLVMSupport.so.14git+0x1f6b73)
#1 0x00007fdee365892e llvm::sys::RunSignalHandlers() (/home/xgupta/llvm/llvm-upstream/build/bin/../lib/libLLVMSupport.so.14git+0x1f492e)
#2 0x00007fdee365b03a SignalHandler(int) Signals.cpp:0:0
#3 0x00007fdee3c16870 restore_rt sigaction.c:0:0
#4 0x00007fdee461a9e4 llvm::orc::EPCIndirectionUtils::Create(llvm::orc::ExecutorProcessControl&) (/home/xgupta/llvm/llvm-upstream/build/bin/../lib/libLLVMOrcJIT.so.14git+0xfb9e4)
#5 0x0000000000208781 main (./LLJITWithTargetProcessControl+0x208781)
#6 0x00007fdee2f48b25 libc_start_main (/usr/lib/libc.so.6+0x27b25)
#7 0x0000000000207fde _start (./LLJITWithTargetProcessControl+0x207fde)
[1] 52081 segmentation fault (core dumped) ./LLJITWithTargetProcessControl

[sgraenitz]

Thanks @xgupta for your note! The parameter passed to EPCIndirectionUtils::Create() in the example was referencing a moved-from value. This caused the segfault. Unfortunately, the examples don't have good test coverage so far.

[xgupta]

In D110260#3018110, @sgraenitz wrote:

Thanks @xgupta for your note! The parameter passed to EPCIndirectionUtils::Create() in the example was referencing a moved-from value. This caused the segfault. Unfortunately, the examples don't have good test coverage so far.

Yeah we need testcases, now it says

JIT session error: Symbols not found: [ return1 ]
JIT session error: Failed to materialize symbols: { (main, { foo_body }) }
Unable to lazily compile function. Exiting.

Anyways the current patch LGTM.

[sgraenitz]

In D110260#3018412, @xgupta wrote:

Yeah we need testcases, now it says

JIT session error: Symbols not found: [ return1 ]
JIT session error: Failed to materialize symbols: { (main, { foo_body }) }
Unable to lazily compile function. Exiting.

Interesting, it does work for me now on macOS with both, shared libs on and off. Can you please check if you get something like this as well:

➜ nm bin/LLJITWithExecutorProcessControl | grep return1
0000000100004c10 T _return1

[xgupta]

In D110260#3018555, @sgraenitz wrote:

Interesting, it does work for me now on macOS with both, shared libs on and off. Can you please check if you get something like this as well:

➜ nm bin/LLJITWithExecutorProcessControl | grep return1
0000000100004c10 T _return1

nothing returns, I am on arch linux (an rolling release distribution which has all the latest packages) and building LLVM with shared libs config.
cmake ../llvm -DLLVM_TARGETS_TO_BUILD="X86" -DCMAKE_BUILD_TYPE=Release -DLLVM_BUILD_TOOLS=ON -DLLVM_USE_LINKER=lld -DBUILD_SHARED_LIBS=ON -DCMAKE_C_COMPILER=/usr/local/bin/clang \
-DCMAKE_CXX_COMPILER=/usr/local/bin/clang++ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DLLVM_BUILD_EXAMPLES=ON

[xgupta]

Problem is fixed with D110345, Thank you very much for quick fixes.

[sgraenitz]

FYI Included one more typo fix in ExecutorAddress.h

clang/docs/ClangFormattedStatus.rst

* - llvm/examples/OrcV2Examples/LLJITWithOptimizingIRTransform
      - `1`
      - `0`
      - :good:`100%`
    * - llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging
      - `3`
      - `3`
      - `0`
      - :good:`100%`
-   * - llvm/examples/OrcV2Examples/LLJITWithTargetProcessControl
+   * - llvm/examples/OrcV2Examples/LLJITWithExecutorProcessControl
      - `1`
      - `1`
      - `0`
      - :good:`100%`
    * - llvm/examples/OrcV2Examples/LLJITWithThinLTOSummaries
      - `1`
      - `0`
      - `1`

llvm/examples/OrcV2Examples/CMakeLists.txt

 add_subdirectory(LLJITDumpObjects)
 add_subdirectory(LLJITWithCustomObjectLinkingLayer)
+add_subdirectory(LLJITWithExecutorProcessControl)
 add_subdirectory(LLJITWithGDBRegistrationListener)
 add_subdirectory(LLJITWithInitializers)
 add_subdirectory(LLJITWithLazyReexports)
 add_subdirectory(LLJITWithObjectCache)
 add_subdirectory(LLJITWithObjectLinkingLayerPlugin)
 add_subdirectory(LLJITWithOptimizingIRTransform)
-add_subdirectory(LLJITWithTargetProcessControl)
 add_subdirectory(LLJITWithThinLTOSummaries)
 add_subdirectory(OrcV2CBindingsAddObjectFile)
 add_subdirectory(OrcV2CBindingsBasicUsage)
 add_subdirectory(OrcV2CBindingsDumpObjects)
 add_subdirectory(OrcV2CBindingsIRTransforms)
 add_subdirectory(OrcV2CBindingsReflectProcessSymbols)
 add_subdirectory(OrcV2CBindingsRemovableCode)
 add_subdirectory(OrcV2CBindingsLazy)
 add_subdirectory(OrcV2CBindingsVeryLazy)
 
 if(CMAKE_HOST_UNIX)
   add_subdirectory(LLJITWithRemoteDebugging)
 endif()

llvm/examples/OrcV2Examples/LLJITWithExecutorProcessControl/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   Core
   ExecutionEngine
   IRReader
   OrcJIT
   Support
   nativecodegen
   )
 
-add_llvm_example(LLJITWithTargetProcessControl
-  LLJITWithTargetProcessControl.cpp
+add_llvm_example(LLJITWithExecutorProcessControl
+  LLJITWithExecutorProcessControl.cpp
   )

llvm/include/llvm/ExecutionEngine/Orc/Shared/ExecutorAddress.h

public:
   /// Create an ExecutorAddress from the given pointer.
   /// Warning: This should only be used when JITing in-process.
   template <typename T> static ExecutorAddress fromPtr(T *Value) {
     return ExecutorAddress(
         static_cast<uint64_t>(reinterpret_cast<uintptr_t>(Value)));
   }
 
   /// Cast this ExecutorAddress to a pointer of the given type.
-  /// Warning: This should only be esude when JITing in-process.
+  /// Warning: This should only be used when JITing in-process.
   template <typename T> T toPtr() const {
     static_assert(std::is_pointer<T>::value, "T must be a pointer type");
     uintptr_t IntPtr = static_cast<uintptr_t>(Addr);
     assert(IntPtr == Addr &&
            "JITTargetAddress value out of range for uintptr_t");
     return reinterpret_cast<T>(IntPtr);
   }
 

llvm/include/llvm/ExecutionEngine/Orc/SimpleRemoteEPC.h

 //
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_EXECUTIONENGINE_ORC_SIMPLEREMOTEEPC_H
 #define LLVM_EXECUTIONENGINE_ORC_SIMPLEREMOTEEPC_H
 
 #include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/FunctionExtras.h"
-#include "llvm/ExecutionEngine/Orc/EPCGenericJITLinkMemoryManager.h"
 #include "llvm/ExecutionEngine/Orc/EPCGenericMemoryAccess.h"
 #include "llvm/ExecutionEngine/Orc/ExecutorProcessControl.h"
 #include "llvm/ExecutionEngine/Orc/Shared/SimpleRemoteEPCUtils.h"
 #include "llvm/Support/Error.h"
 #include "llvm/Support/MSVCErrorWorkarounds.h"
 
 #include <future>
 

llvm/lib/ExecutionEngine/Orc/Shared/SimpleRemoteEPCUtils.cpp

OpC = static_cast<SimpleRemoteEPCOpcode>(static_cast<uint64_t>(
         *((support::ulittle64_t *)(HeaderBuffer + FDMsgHeader::OpCOffset))));
     SeqNo =
         *((support::ulittle64_t *)(HeaderBuffer + FDMsgHeader::SeqNoOffset));
     TagAddr.setValue(
         *((support::ulittle64_t *)(HeaderBuffer + FDMsgHeader::TagAddrOffset)));
 
     if (MsgSize < FDMsgHeader::Size) {
       Err = joinErrors(std::move(Err),
-                       make_error<StringError>("Mesasge size too small",
+                       make_error<StringError>("Message size too small",
                                                inconvertibleErrorCode()));
       break;
     }
 
     // Read the argument bytes.
     SimpleRemoteEPCArgBytesVector ArgBytes;
     ArgBytes.resize(MsgSize - FDMsgHeader::Size);
     if (auto Err2 = readBytes(ArgBytes.data(), ArgBytes.size())) {