This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][AIX] Remove locale fallbacks for old OS levels
ClosedPublic

Authored by daltenty on Sep 21 2021, 9:48 AM.

Details

Summary

These routines were add years ago during initial porting attempts to AIX and are mostly build hacks for routines which we're missing at the time, but are available now on recent AIX OS levels.

Thus builds on modern AIX OS levels no longer need these and they cause problems if you try to build the library with a generic triple (i.e. powerpc-ibm-aix) as we'll pull them in and encounter duplicate definitions from the OS.

Diff Detail

Event Timeline

daltenty created this revision.Sep 21 2021, 9:48 AM
daltenty requested review of this revision.Sep 21 2021, 9:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2021, 9:48 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Sep 21 2021, 3:34 PM
ldionne added a subscriber: ldionne.

Ship it. You can ignore the CI failure, it's been fixed on main now.

This revision is now accepted and ready to land.Sep 21 2021, 3:34 PM
This revision was landed with ongoing or failed builds.Sep 21 2021, 6:14 PM
This revision was automatically updated to reflect the committed changes.
libcxx/include/CMakeLists.txt