Page MenuHomePhabricator

[mlir] Always create a list of alias scopes when emitting LLVM IR
ClosedPublic

Authored by ftynse on Sep 21 2021, 2:45 AM.

Details

Summary

Previously, the translation to LLVM IR would emit IR that directly uses
a scope metadata node in case only one scope was in use in alias.scopes
or noalias metadata. It should always be a list of scopes. The verifier
change in 8700f2bd36bb9b7d7075ed4dac0aef92b9489237 enforced this and
broke the test. Fix the translation to always create a list of scopes
using a new metadata node, update and reenable the respective test.

Fixes PR51919.

Diff Detail

Event Timeline

ftynse created this revision.Sep 21 2021, 2:45 AM
ftynse requested review of this revision.Sep 21 2021, 2:45 AM

Thanks!

Can you cross-check with https://reviews.llvm.org/D110189 ? I think you have the same fix but the test update is slightly different.

mehdi_amini accepted this revision.Sep 21 2021, 11:24 AM
This revision is now accepted and ready to land.Sep 21 2021, 11:24 AM

Yeah, the change is the same and the matcher differs only by variable names.

This revision was landed with ongoing or failed builds.Sep 21 2021, 3:01 PM
This revision was automatically updated to reflect the committed changes.