[AMDGPU] Change ASAN init/fini kernels linkage to external.

[pvellien]

Summary

HSA runtime fails to find the symbols for Init and Fini kernels as they mark with internal linkage, changing the linkage to external to fix those errors.

[yaxunl]

need a test

[pvellien]

Hi @yaxunl It will helpful to know what kind of test is expected to test the linkage type of generated init/fini kernels. The related test-cases for init/fini kernels are added in this patch - https://reviews.llvm.org/D105682

[yaxunl]

In D110054#3009960, @pvellien wrote:

Hi @yaxunl It will helpful to know what kind of test is expected to test the linkage type of generated init/fini kernels. The related test-cases for init/fini kernels are added in this patch - https://reviews.llvm.org/D105682

Need a test to demonstrate and confirm the linkage change.

[pvellien]

Added test.

[foad]

Nit: first line of commit message should be more like [AMDGPU] Change ASAN init/fini kernels to use external linkage (with a capital letter but without a period). And there's no need to repeat this in the body of the commit message. Either leave it blank, or add some text that explains the reason for the change.

[pvellien]

@foad thanks.

[yaxunl]

LGTM. Thanks.

[pvellien]

Hi, The failures in the debian builds are not related to this patch changes. I don't have a commit access to llvm trunk, could any of you please land this patch on my behalf. Thanks a lot for your time.

[gandhi21299]

I can help commit this patch. Can you please rebase your work with the latest main branch and upload the patch again, @pvellien ? Thanks

[pvellien]

Rebase on top.

[pvellien]

In D110054#3024859, @gandhi21299 wrote:

I can help commit this patch. Can you please rebase your work with the latest main branch and upload the patch again, @pvellien ? Thanks

thanks @gandhi21299

[gandhi21299]

error: lib/Target/AMDGPU/AMDGPUCtorDtorLowering.cpp: No such file or directory
error: test/CodeGen/AMDGPU/lower-ctor-dtor.ll: No such file or directory
error: test/CodeGen/AMDGPU/lower-multiple-ctor-dtor.ll: No such file or directory

These errors were issued again despite llvm-project being up to date on my system. I manually implemented the changes. I am running all tests anyways and will push it once the tests pass.

llvm/lib/Target/AMDGPU/AMDGPUCtorDtorLowering.cpp

 public:
   Function *createInitOrFiniKernelFunction(Module &M, bool IsCtor) {
     StringRef InitOrFiniKernelName = "amdgcn.device.init";
     if (!IsCtor)
       InitOrFiniKernelName = "amdgcn.device.fini";
 
     Function *InitOrFiniKernel = Function::createWithDefaultAttr(
         FunctionType::get(Type::getVoidTy(M.getContext()), false),
-        GlobalValue::InternalLinkage, 0, InitOrFiniKernelName, &M);
+        GlobalValue::ExternalLinkage, 0, InitOrFiniKernelName, &M);
     BasicBlock *InitOrFiniKernelBB =
         BasicBlock::Create(M.getContext(), "", InitOrFiniKernel);
     ReturnInst::Create(M.getContext(), InitOrFiniKernelBB);
 
     InitOrFiniKernel->setCallingConv(CallingConv::AMDGPU_KERNEL);
     if (IsCtor)
       InitOrFiniKernel->addFnAttr("device-init");
     else

llvm/test/CodeGen/AMDGPU/lower-ctor-dtor.ll

 ; RUN: opt -S -mtriple=amdgcn--  -amdgpu-lower-ctor-dtor < %s | FileCheck %s
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx700 -filetype=obj -o - < %s | llvm-readelf -s - 2>&1 | FileCheck %s -check-prefix=CHECK-VIS
 
 @llvm.global_ctors = appending addrspace(1) global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 1, void ()* @foo, i8* null }]
 @llvm.global_dtors = appending addrspace(1) global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 1, void ()* @bar, i8* null }]
 
 ; CHECK-LABEL: amdgpu_kernel void @amdgcn.device.init() #0
 ; CHECK-NEXT: call void @foo
 
 ; CHECK-LABEL: amdgpu_kernel void @amdgcn.device.fini() #1
 ; CHECK-NEXT: call void @bar
 
+; CHECK-VIS: FUNC   GLOBAL PROTECTED {{.*}} amdgcn.device.init
+; CHECK-VIS: OBJECT GLOBAL DEFAULT {{.*}} amdgcn.device.init.kd
+; CHECK-VIS: FUNC   GLOBAL PROTECTED {{.*}} amdgcn.device.fini
+; CHECK-VIS: OBJECT   GLOBAL DEFAULT {{.*}} amdgcn.device.fini.kd
+
 define internal void @foo() {
   ret void
 }
 
 define internal void @bar() {
   ret void
 }
 
 ; CHECK: attributes #0 = { "device-init" }
 ; CHECK: attributes #1 = { "device-fini" } 

llvm/test/CodeGen/AMDGPU/lower-multiple-ctor-dtor.ll

 ; RUN: opt -S -mtriple=amdgcn--  -amdgpu-lower-ctor-dtor < %s | FileCheck %s
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx700 -filetype=obj -o - < %s | llvm-readelf -s - 2>&1 | FileCheck %s -check-prefix=CHECK-VIS
 
 @llvm.global_ctors = appending addrspace(1) global [2 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 1, void ()* @foo, i8* null }, { i32, void ()*, i8* } { i32 1, void ()* @foo.5, i8* null }]
 @llvm.global_dtors = appending addrspace(1) global [2 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 1, void ()* @bar, i8* null }, { i32, void ()*, i8* } { i32 1, void ()* @bar.5, i8* null }]
 
 ; CHECK-LABEL: amdgpu_kernel void @amdgcn.device.init() #0
 ; CHECK-NEXT: call void @foo
 ; CHECK-NEXT: call void @foo.5
 
 ; CHECK-LABEL: amdgpu_kernel void @amdgcn.device.fini() #1
 ; CHECK-NEXT: call void @bar
 ; CHECK-NEXT: call void @bar.5
 
+; CHECK-VIS: FUNC   GLOBAL PROTECTED {{.*}} amdgcn.device.init
+; CHECK-VIS: OBJECT GLOBAL DEFAULT {{.*}} amdgcn.device.init.kd
+; CHECK-VIS: FUNC   GLOBAL PROTECTED {{.*}} amdgcn.device.fini
+; CHECK-VIS: OBJECT   GLOBAL DEFAULT {{.*}} amdgcn.device.fini.kd
+
 define internal void @foo() {
   ret void
 }
 
 define internal void @bar() {
   ret void
 }
 
 define internal void @foo.5() {
   ret void
 }
 
 define internal void @bar.5() {
   ret void
 }
 
 ; CHECK: attributes #0 = { "device-init" }
-; CHECK: attributes #1 = { "device-fini" } 
+; CHECK: attributes #1 = { "device-fini" }
 No newline at end of file