Fixing vector add pattern that incorrectly returns success.

[benvanik]

Summary

The pattern is returning success even if it does no work leading to pattern application running up to the max iteration count and failing.

[nicolasvasilache]

thanks @benvanik !

mlir/lib/Dialect/Vector/VectorOps.cpp

auto canonicalize = [&](Value maybeContraction,
         }
       }
       return vector::ContractionOp();
     };
 
     Value a = addOp->getOperand(0), b = addOp->getOperand(1);
     vector::ContractionOp contract = canonicalize(a, b);
     contract = contract ? contract : canonicalize(b, a);
-    return success();
+    return contract ? success() : failure();
   }
 };
 
 void ContractionOp::getCanonicalizationPatterns(RewritePatternSet &results,
                                                 MLIRContext *context) {
   results.add<CanonicalizeContractAdd<AddIOp>, CanonicalizeContractAdd<AddFOp>>(
       context);
 }