[libc++][test] Remove disable_missing_braces_warning.h from tests

[jloser]

Summary

Several tests include disable_missing_braces_warning.h but do not need
to. Remove the include.

Inspired from discussion at https://reviews.llvm.org/D109668

[• Quuxplusone]

If buildkite is actually OK with this, then I'm OK with it.

But I assume that buildkite would not be OK with this as-is; I assume it'll produce that warning diagnostic. But I think we should fix the warning appropriately, e.g. by changing const std::array<long, 5> arr = {4, 5, 6, 7, 8}; to const std::array<long, 5> arr = {{4, 5, 6, 7, 8}};. I believe such changes will be trivially easy, except for apply_extended_types.pass.cpp, where the missing braces are inside a template that's used sometimes with array (which needs double braces) and sometimes with tuple (which needs single braces).

I don't understand why you changed only these few tests. E.g. why not any of the tests under std/containers/sequences/array/? and why not std/iterators/iterator.range/begin-end.pass.cpp?

[Mordante]

LGTM. But I too would prefer remove all no longer needed #include "disable_missing_braces_warning.h" in this commit and remove the then obsolete header.

@Quuxplusone Am I missing something? AFAIK const std::array<long, 5> arr = {4, 5, 6, 7, 8}; is valid C++11.

[• Quuxplusone]

@Quuxplusone Am I missing something? AFAIK const std::array<long, 5> arr = {4, 5, 6, 7, 8}; is valid C++11.

It's definitely valid, but I had assumed (wrongly, it seems) that it would still trigger a non-fatal warning on Clang and/or GCC, which would have been the point of the header: to avoid that non-fatal warning.
However, at least on Godbolt,

• I cannot reproduce any such warning on Clang at all
• I can reproduce it on GCC but only by explicitly passing -Wmissing-braces; it's not part of -Wall -Wextra

So yeah, @jloser, can we see what happens if you just git rm disable_missing_braces_warning.h and remove all its uses? I now predict that we'll see buildkite totally happy with that.

[ldionne]

Agreed with the other reviewers, please try removing disable_missing_braces_warning,h entirely.

[jloser]

Remove rest of disable_missing_braces_warning.h from other tests.
Remove header disable_missing_braces_warning.h

[ldionne]

Thanks! LGTM if CI passes.

[jloser]

In D109711#3010490, @ldionne wrote:

Thanks! LGTM if CI passes.

CI is failing in the runtimes build (https://buildkite.com/llvm-project/libcxx-ci/builds/5444#eabe837f-7b55-4767-a14b-24ef963ad3dc) but this looks unrelated to my changes. I didn't touch this test so its behavior should be unchanged. Safe to land this, or what would you like me to do?

[jloser]

Rebase to kick the bots

[jloser]

Rebase with main to fix CI

[jloser]

Poke buildbots due to failure from out-of-space on build bot

[jloser]

Kick the bots again...

libcxx/test/std/containers/views/span.cons/deduct.pass.cpp

 #include <algorithm>
 #include <array>
 #include <cassert>
 #include <string>
 #include <type_traits>
 
 #include "test_macros.h"
 
-// std::array is explicitly allowed to be initialized with A a = { init-list };.
-// Disable the missing braces warning for this reason.
-#include "disable_missing_braces_warning.h"
-
 int main(int, char**)
 {
     {
     int arr[] = {1,2,3};
     std::span s{arr};
     using S = decltype(s);
     ASSERT_SAME_TYPE(S, std::span<int, 3>);
     assert((std::equal(std::begin(arr), std::end(arr), s.begin(), s.end())));

libcxx/test/std/utilities/tuple/tuple.tuple/tuple.apply/apply.pass.cpp

 #include <tuple>
 #include <array>
 #include <utility>
 #include <cassert>
 
 #include "test_macros.h"
 #include "type_id.h"
 
-// std::array is explicitly allowed to be initialized with A a = { init-list };.
-// Disable the missing braces warning for this reason.
-#include "disable_missing_braces_warning.h"
-
-
 constexpr int constexpr_sum_fn() { return 0; }
 
 template <class ...Ints>
 constexpr int constexpr_sum_fn(int x1, Ints... rest) { return x1 + constexpr_sum_fn(rest...); }
 
 struct ConstexprSumT {
   constexpr ConstexprSumT() = default;
   template <class ...Ints>

libcxx/test/std/utilities/tuple/tuple.tuple/tuple.apply/apply_extended_types.pass.cpp

 // named by INVOKE but that are not actual callable objects. These include
 // bullets 1-4 of invoke.
 
 #include <tuple>
 #include <array>
 #include <utility>
 #include <cassert>
 
-// std::array is explicitly allowed to be initialized with A a = { init-list };.
-// Disable the missing braces warning for this reason.
 #include "test_macros.h"
-#include "disable_missing_braces_warning.h"
 
 int count = 0;
 
 struct A_int_0
 {
     A_int_0() : obj1(0){}
     A_int_0(int x) : obj1(x) {}
     int mem1() { return ++count; }

libcxx/test/std/utilities/tuple/tuple.tuple/tuple.apply/make_from_tuple.pass.cpp

 #include <array>
 #include <utility>
 #include <string>
 #include <cassert>
 
 #include "test_macros.h"
 #include "type_id.h"
 
-// std::array is explicitly allowed to be initialized with A a = { init-list };.
-// Disable the missing braces warning for this reason.
-#include "disable_missing_braces_warning.h"
-
 template <class Tuple>
 struct ConstexprConstructibleFromTuple {
   template <class ...Args>
   explicit constexpr ConstexprConstructibleFromTuple(Args&&... xargs)
       : args{std::forward<Args>(xargs)...} {}
   Tuple args;
 };