Page MenuHomePhabricator

[Attributor] Ensure store uses are correlated with reloads
AcceptedPublic

Authored by jdoerfert on Sep 12 2021, 1:31 PM.

Details

Summary

While we skipped uses in stores if we can find all copies of the value
when the memory is loaded, we did not correlate the use in the store
with the use in the load. So far this lead to less precise results in the
offset calculations which prevented deductions. With the new
EquivalentUseCB callback argument the user of checkForAllUses can be
informed of the correlation and act on it appropriately.

Diff Detail

Event Timeline

jdoerfert created this revision.Sep 12 2021, 1:31 PM
jdoerfert requested review of this revision.Sep 12 2021, 1:31 PM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
kuter accepted this revision.Sep 19 2021, 9:52 AM

LGTM.

This revision is now accepted and ready to land.Sep 19 2021, 9:52 AM