Page MenuHomePhabricator

[XCOFF] Fix the program abortion issue.
ClosedPublic

Authored by Esme on Sep 9 2021, 10:29 PM.

Details

Summary

Use std::move(E) to avoid Program aborted due to an unhandled Error:..
This is found during testing the error paths in D98003.
See the error case 1 in llvm/test/tools/obj2yaml/XCOFF/invalid.yaml of D98003.

Diff Detail

Event Timeline

Esme created this revision.Sep 9 2021, 10:29 PM
Esme requested review of this revision.Sep 9 2021, 10:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2021, 10:29 PM
jhenderson accepted this revision.Sep 10 2021, 1:30 AM

LGTM.

llvm/lib/Object/XCOFFObjectFile.cpp
296

Fix this in a separate NFC commit. No need for a review.

This revision is now accepted and ready to land.Sep 10 2021, 1:30 AM