16]PAIR
ClosedPublic
Actions

Authored by LiuChen3 on Sep 9 2021, 8:13 PM.

Details

Reviewers

pengfei
craig.topper
LuoYuanke
xiangzhangllvm

Commits

rG7f793b102c9a: [X86][NFC] Remove unused encoding string: VK[1/2/4/8/16]PAIR

Summary

This is also a bug. The VK[1/2/4/8/16]PAIR here should be VK[1/2/4/8/16]Pair which has its
custom PrintMethod and ParserMatchClass. However we don't have any instructions using vvvv
and ModR/M.REG field so this issue is not exposed.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	3,260 ms	x64 debian > libarcher.races::task-dependency.c Script: -- : 'RUN: at line 13'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -g -O1 -fsanitize=thread -I /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests -I /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/src -L /var/lib/buildkite-agent/builds/llvm-project/build/lib -Wl,-rpath,/var/lib/buildkite-agent/builds/llvm-project/build/lib /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/task-dependency.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/task-dependency.c.tmp -latomic && env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1' /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/deflake.bash /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/task-dependency.c.tmp 2>&1 \| tee /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/task-dependency.c.tmp.log \| /var/lib/buildkite-agent/builds/llvm-project/build/./bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/task-dependency.c
	770 ms	x64 debian > libomp.lock::omp_init_lock.c Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -I /var/lib/buildkite-agent/builds/llvm-project/openmp/runtime/test -I /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/src -L /var/lib/buildkite-agent/builds/llvm-project/build/lib -I /var/lib/buildkite-agent/builds/llvm-project/openmp/runtime/test/ompt /var/lib/buildkite-agent/builds/llvm-project/openmp/runtime/test/lock/omp_init_lock.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/test/lock/Output/omp_init_lock.c.tmp -lm -latomic && /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/test/lock/Output/omp_init_lock.c.tmp

Event Timeline

LiuChen3 requested review of this revision.Sep 9 2021, 8:13 PM

LiuChen3 created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2021, 8:13 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

LiuChen3 added reviewers: pengfei, craig.topper, LuoYuanke, xiangzhangllvm.Sep 9 2021, 8:15 PM

LGTM

This revision is now accepted and ready to land.Sep 9 2021, 8:26 PM

Change VK1PAIR to VK1Pair may be reasonable. (keep same with other xxRegisterEncodingFromString for future ISA.)

lib/Target/X86/X86RegisterInfo.td:629:def VK1PAIR : RegisterClass<"X86", [untyped], 16, (add KPAIRS)> {let Size = 32;}
lib/Target/X86/X86InstrInfo.td:817:def VK1Pair : RegisterOperand<VK1PAIR, "printVKPair"> {

In D109564#2993400, @xiangzhangllvm wrote:

Change VK1PAIR to VK1Pair may be reasonable. (keep same with other xxRegisterEncodingFromString for future ISA.)

lib/Target/X86/X86RegisterInfo.td:629:def VK1PAIR : RegisterClass<"X86", [untyped], 16, (add KPAIRS)> {let Size = 32;}
lib/Target/X86/X86InstrInfo.td:817:def VK1Pair : RegisterOperand<VK1PAIR, "printVKPair"> {

I think it is fine to remove it. Tablegen will issue an error if a new instruction is added. At that point its easy to add back.

Harbormaster completed remote builds in B123350: Diff 371773.Sep 9 2021, 8:58 PM

Yes, make sense

This revision was landed with ongoing or failed builds.Sep 9 2021, 10:43 PM

Closed by commit rG7f793b102c9a: [X86][NFC] Remove unused encoding string: VK[1/2/4/8/16]PAIR (authored by LiuChen3). · Explain Why

This revision was automatically updated to reflect the committed changes.

LiuChen3 added a commit: rG7f793b102c9a: [X86][NFC] Remove unused encoding string: VK[1/2/4/8/16]PAIR.

Thanks for reviewing this patch!