Page MenuHomePhabricator
Differential D109545

[mlir][sparse] add folding to sparse_tensor.convert
ClosedPublic
Actions

Authored by aartbik on Sep 9 2021, 2:39 PM.

Details

Reviewers
ThomasRaoux
Commits
rG066d786ce03b: [mlir][sparse] add folding to sparse_tensor.convert
Summary

folds conversion between identical types (with tests)

Diff Detail

Event Timeline

aartbik created this revision.Sep 9 2021, 2:39 PM
Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan and 18 others. · View Herald TranscriptSep 9 2021, 2:39 PM
aartbik requested review of this revision.Sep 9 2021, 2:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2021, 2:39 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
aartbik updated this revision to Diff 371725.Sep 9 2021, 2:41 PM

rebase with diff in main

aartbik added a reviewer: ThomasRaoux.Sep 9 2021, 2:41 PM
ThomasRaoux accepted this revision.Sep 9 2021, 2:45 PM
ThomasRaoux added inline comments.
mlir/test/Dialect/SparseTensor/conversion.mlir
115–121

this looks like the same test as in fold.mlir? Is that on purpose?

This revision is now accepted and ready to land.Sep 9 2021, 2:45 PM
aartbik marked an inline comment as done.Sep 9 2021, 2:48 PM
aartbik added inline comments.
mlir/test/Dialect/SparseTensor/conversion.mlir
115–121

Almost, but it has also converted the type into the opaque pointer! Just to make sure we don't fold "too late".

Harbormaster completed remote builds in B123311: Diff 371725.Sep 9 2021, 3:22 PM
Closed by commit rG066d786ce03b: [mlir][sparse] add folding to sparse_tensor.convert (authored by aartbik). · Explain WhySep 9 2021, 3:45 PM
This revision was automatically updated to reflect the committed changes.
aartbik marked an inline comment as done.
aartbik added a commit: rG066d786ce03b: [mlir][sparse] add folding to sparse_tensor.convert.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
SparseTensor/
IR/
1 line
lib/
Dialect/
SparseTensor/
IR/
6 lines
test/
Dialect/
SparseTensor/
8 lines
20 lines

Diff 371738

View Options

mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorOps.td

Loading...
View Options

mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

Loading...
View Options

mlir/test/Dialect/SparseTensor/conversion.mlir

Loading...
View Options

mlir/test/Dialect/SparseTensor/fold.mlir

Loading...