Annotate `llvm.eh.sjlj.setjmp` as `returns_twice`
Needs ReviewPublic
Actions

Authored by xtkoba on Sep 3 2021, 10:40 AM.

Details

Reviewers

Summary

In LLVM, some optimizations are disabled for functions that return twice. For instance, register coalescing in those functions is disabled by D77767. Currently, this does not apply to __builtin_setjmp, because the intrinsic function llvm.eh.sjlj.setjmp is not annotated as returns_twice.

In the proposed change, we annotate llvm.eh.sjlj.setjmp as returns_twice. This fixes PR50234.

Diff Detail

Unit TestsFailed
View All

	Time	Test
	121,540 ms	x64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases/Linux::uar_signals.cpp Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -shared-libasan -std=c++11 -O1 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/asan/TestCases/Linux/uar_signals.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/asan/X86_64LinuxDynamicConfig/TestCases/Linux/Output/uar_signals.cpp.tmp -pthread && /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/asan/X86_64LinuxDynamicConfig/TestCases/Linux/Output/uar_signals.cpp.tmp

Event Timeline

xtkoba requested review of this revision.Sep 3 2021, 10:40 AM

xtkoba created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2021, 10:40 AM

Herald added subscribers: llvm-commits, jdoerfert. · View Herald Transcript

Harbormaster completed remote builds in B122552: Diff 370617.Sep 3 2021, 11:20 AM

Tests revised.
Reformatted.

Herald added subscribers: pengfei, nemanjai. · View Herald TranscriptSep 3 2021, 12:18 PM

Harbormaster completed remote builds in B122562: Diff 370642.Sep 3 2021, 1:27 PM

It has been revealed that this also fixes PR51729.

Diff context extended

Harbormaster completed remote builds in B122618: Diff 370725.Sep 4 2021, 4:09 AM

xtkoba added a reviewer: jdoerfert.Sep 4 2021, 2:11 PM

I'm not a reviewer, but this looks good to me. (At first I thought that the required tablegen additions were missing, but they were at the end of the list of files so I missed them :) )

• hafixo added a commit: rCRT373035: hwasan: Compatibility fixes for short granules..Sep 6 2021, 12:44 AM

• hafixo added a commit: rGc336557f0238: hwasan: Compatibility fixes for short granules..Sep 6 2021, 12:47 AM

thopre removed a commit: rGc336557f0238: hwasan: Compatibility fixes for short granules..Sep 7 2021, 2:47 AM

thopre removed a commit: rCRT373035: hwasan: Compatibility fixes for short granules..Sep 7 2021, 2:51 AM

LG, but I'd prefer an explicit IR test. There should be some, if not add a new one to verify we add returns twice properly.