Page MenuHomePhabricator

Fix unused variable in release build.
ClosedPublic

Authored by mravishankar on Aug 30 2021, 6:12 PM.

Diff Detail

Event Timeline

mravishankar created this revision.Aug 30 2021, 6:12 PM
mravishankar requested review of this revision.Aug 30 2021, 6:12 PM
rriddle added inline comments.Aug 30 2021, 6:15 PM
mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
1216–1217

This looks like what was intended.

Rebase

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
1216–1217

Dropped use of intAttr and used intVal instead.

rriddle added inline comments.Aug 30 2021, 7:33 PM
mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
1216–1217

Why though? That will result in an unnecessary dyn_cast to Value:

https://github.com/llvm/llvm-project/blob/ba72cfe73464b9f1e06f2cd2bed93b07483c0be1/mlir/lib/Dialect/Utils/StaticValueUtils.cpp#L69

I assume the original intention was avoiding that, given the assert message.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2021, 7:35 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.