This is an archive of the discontinued LLVM Phabricator instance.

Differential D108901

[Sparc] Create an error when `__builtin_longjmp` is used
ClosedPublic

Authored by xtkoba on Aug 29 2021, 3:44 PM.

Details

Reviewers
dcederman
LemonBoy
Commits
rGeeb4266f8137: [Sparc] Create an error when `__builtin_longjmp` is used
Summary

For Sparc, the support for builtin setjmp/longjmp is removed by https://reviews.llvm.org/D51487. An error should be created when compiling a C code using __builtin_setjmp or __builtin_longjmp.

Diff Detail

Event Timeline

xtkoba created this revision.Aug 29 2021, 3:44 PM
Herald added subscribers: jrtc27, fedor.sergeev, jyknight. · View Herald TranscriptAug 29 2021, 3:44 PM
xtkoba requested review of this revision.Aug 29 2021, 3:44 PM
Harbormaster completed remote builds in B121679: Diff 369345.Aug 29 2021, 4:32 PM
rsmith added a reviewer: dcederman.Aug 30 2021, 11:38 AM
brad added a reviewer: LemonBoy.Sep 17 2021, 6:50 PM
dcederman accepted this revision.Oct 13 2021, 1:34 AM

LGTM.

This revision is now accepted and ready to land.Oct 13 2021, 1:34 AM
Closed by commit rGeeb4266f8137: [Sparc] Create an error when `__builtin_longjmp` is used (authored by xtkoba, committed by brad). · Explain WhyDec 3 2021, 8:42 PM
This revision was automatically updated to reflect the committed changes.
brad added a commit: rGeeb4266f8137: [Sparc] Create an error when `__builtin_longjmp` is used.
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2021, 8:42 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
lib/
Basic/
Targets/
3 lines
test/
Sema/
2 lines

Diff 369345

clang/lib/Basic/Targets/Sparc.h

Context not available.
bool hasFeature(StringRef Feature) const override; bool hasFeature(StringRef Feature) const override;
bool hasSjLjLowering() const override { return true; }
ArrayRef<Builtin::Info> getTargetBuiltins() const override { ArrayRef<Builtin::Info> getTargetBuiltins() const override {
// FIXME: Implement! // FIXME: Implement!
return None; return None;
Context not available.
void getTargetDefines(const LangOptions &Opts, void getTargetDefines(const LangOptions &Opts,
MacroBuilder &Builder) const override; MacroBuilder &Builder) const override;
bool hasSjLjLowering() const override { return true; }
bool hasExtIntType() const override { return true; } bool hasExtIntType() const override { return true; }
}; };
Context not available.

clang/test/Sema/builtin-longjmp.c

Context not available.
// RUN: %clang_cc1 -triple x86_64-windows -emit-llvm < %s| FileCheck %s // RUN: %clang_cc1 -triple x86_64-windows -emit-llvm < %s| FileCheck %s
// RUN: %clang_cc1 -triple powerpc-unknown-unknown -emit-llvm < %s| FileCheck %s // RUN: %clang_cc1 -triple powerpc-unknown-unknown -emit-llvm < %s| FileCheck %s
// RUN: %clang_cc1 -triple powerpc64-unknown-unknown -emit-llvm < %s| FileCheck %s // RUN: %clang_cc1 -triple powerpc64-unknown-unknown -emit-llvm < %s| FileCheck %s
// RUN: %clang_cc1 -triple sparc-eabi-unknown -emit-llvm < %s | FileCheck %s
// RUN: %clang_cc1 -triple ve-unknown-unknown -emit-llvm < %s | FileCheck %s // RUN: %clang_cc1 -triple ve-unknown-unknown -emit-llvm < %s | FileCheck %s
// RUN: %clang_cc1 -triple aarch64-unknown-unknown -emit-llvm-only -verify %s // RUN: %clang_cc1 -triple aarch64-unknown-unknown -emit-llvm-only -verify %s
// RUN: %clang_cc1 -triple mips-unknown-unknown -emit-llvm-only -verify %s // RUN: %clang_cc1 -triple mips-unknown-unknown -emit-llvm-only -verify %s
// RUN: %clang_cc1 -triple mips64-unknown-unknown -emit-llvm-only -verify %s // RUN: %clang_cc1 -triple mips64-unknown-unknown -emit-llvm-only -verify %s
// RUN: %clang_cc1 -triple sparc-eabi-unknown -emit-llvm-only -verify %s
// Check that __builtin_longjmp and __builtin_setjmp are lowered into // Check that __builtin_longjmp and __builtin_setjmp are lowered into
// IR intrinsics on those architectures that can handle them. // IR intrinsics on those architectures that can handle them.
Context not available.