This is an archive of the discontinued LLVM Phabricator instance.

Differential D108718

[llvm][test][CodeGen] fix up D106030
ClosedPublic

Authored by nickdesaulniers on Aug 25 2021, 11:43 AM.

Details

Reviewers
arsenm
aaron.ballman
Commits
rGb72fd31bdaf2: [llvm][test][CodeGen] fix up D106030
Summary

Fixes missing -mtriple from llc tests, which were failing on non-x86
hosts.

Fixes: D106030

Diff Detail

Event Timeline

nickdesaulniers created this revision.Aug 25 2021, 11:43 AM
Herald added a subscriber: pengfei. · View Herald TranscriptAug 25 2021, 11:43 AM
nickdesaulniers requested review of this revision.Aug 25 2021, 11:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2021, 11:43 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
nickdesaulniers mentioned this in D106030: [Clang] add support for error+warning fn attrs.Aug 25 2021, 11:43 AM
nickdesaulniers added a parent revision: D106030: [Clang] add support for error+warning fn attrs.
nickdesaulniers added a subscriber: aaron.ballman.
dyung added a subscriber: dyung.Aug 25 2021, 11:45 AM

Will this fix the test on the PS4 bot which is an x86-based bot?

https://lab.llvm.org/buildbot/#/builders/139/builds/9299

nickdesaulniers updated this revision to Diff 368696.Aug 25 2021, 11:49 AM
  • prefer -global-isel-abort=0 to not --crash
nickdesaulniers added a comment.Aug 25 2021, 11:51 AM
In D108718#2965604, @dyung wrote:

Will this fix the test on the PS4 bot which is an x86-based bot?

https://lab.llvm.org/buildbot/#/builders/139/builds/9299

I'm not quite sure!

aaron.ballman accepted this revision.Aug 25 2021, 11:56 AM

LGTM!

This revision is now accepted and ready to land.Aug 25 2021, 11:56 AM
arsenm accepted this revision.Aug 25 2021, 12:03 PM
This revision was landed with ongoing or failed builds.Aug 25 2021, 12:11 PM
Closed by commit rGb72fd31bdaf2: [llvm][test][CodeGen] fix up D106030 (authored by nickdesaulniers). · Explain Why
This revision was automatically updated to reflect the committed changes.
nickdesaulniers added a commit: rGb72fd31bdaf2: [llvm][test][CodeGen] fix up D106030.
Harbormaster completed remote builds in B121207: Diff 368696.Aug 25 2021, 12:59 PM

Revision Contents

PathSize
llvm/
test/
CodeGen/
X86/
6 lines

Diff 368701

llvm/test/CodeGen/X86/attr-dontcall.ll

; RUN: not llc -global-isel=0 -fast-isel=0 -stop-after=finalize-isel %s 2>&1 | FileCheck %s ; RUN: not llc -mtriple=x86_64 -global-isel=0 -fast-isel=0 -stop-after=finalize-isel %s 2>&1 | FileCheck %s
; RUN: not llc -global-isel=0 -fast-isel=1 -stop-after=finalize-isel %s 2>&1 | FileCheck %s ; RUN: not llc -mtriple=x86_64 -global-isel=0 -fast-isel=1 -stop-after=finalize-isel %s 2>&1 | FileCheck %s
; RUN: not llc -global-isel=1 -fast-isel=0 -stop-after=irtranslator %s 2>&1 | FileCheck %s ; RUN: not llc -mtriple=x86_64 -global-isel=1 -fast-isel=0 -stop-after=irtranslator -global-isel-abort=0 %s 2>&1 | FileCheck %s
declare void @foo() "dontcall" declare void @foo() "dontcall"
define void @bar() { define void @bar() {
call void @foo() call void @foo()
ret void ret void
} }
; CHECK: error: call to foo marked "dontcall" ; CHECK: error: call to foo marked "dontcall"