This is an archive of the discontinued LLVM Phabricator instance.

[asan] Re-land "Implemented intrinsic for the custom calling convention similar used by HWASan for X86." with a fix.
AbandonedPublic

Authored by kstoimenov on Aug 24 2021, 2:24 PM.

Details

Reviewers
vitalybuka
Summary

This is a re-land of D107850 after fixing 2 issues:

  • link problem was fixed by D108662
  • Bazel build failure by using older syntax for AsanMemaccessTuple

Diff Detail

Event Timeline

kstoimenov created this revision.Aug 24 2021, 2:24 PM
kstoimenov requested review of this revision.Aug 24 2021, 2:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2021, 2:24 PM
kstoimenov retitled this revision from [asan] Roll D107850 forward with a fix: Implemented intrinsic for the custom calling convention similar used by HWASan for X86. to [asan] Re-land "Implemented intrinsic for the custom calling convention similar used by HWASan for X86." with a fix. .Aug 24 2021, 2:39 PM
kstoimenov edited the summary of this revision. (Show Details)
kstoimenov added a reviewer: vitalybuka.
kstoimenov added a subscriber: myhsu.
kstoimenov retitled this revision from [asan] Re-land "Implemented intrinsic for the custom calling convention similar used by HWASan for X86." with a fix. to [asan] Re-land "Implemented intrinsic for the custom calling convention similar used by HWASan for X86." with a fix..

Update after pull.

vitalybuka added a comment.EditedAug 24 2021, 5:28 PM

usually after revert we reopen existing review (also if you revers patches for someone else)
Then
arc diff HEAD^ --update D107850

kstoimenov abandoned this revision.Aug 24 2021, 5:34 PM