This is an archive of the discontinued LLVM Phabricator instance.

Differential D108632

[libc++] Remove workaround for missing declarations on Windows store apps
ClosedPublic

Authored by ldionne on Aug 24 2021, 7:41 AM.

Details

Reviewers
smeenai
mstorsjo
Group Reviewers
Restricted Project
Commits
rGa805a15b287f: [libc++] Remove workaround for missing declarations on Windows store apps
Summary

We don't need preprocessor logic to exclude those declarations when compiling for
the Windows App Store, because that is handled by using_if_exists now.

Diff Detail

Event Timeline

ldionne requested review of this revision.Aug 24 2021, 7:41 AM
ldionne created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2021, 7:41 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B120961: Diff 368343.Aug 24 2021, 9:08 AM
ldionne updated this revision to Diff 368406.Aug 24 2021, 11:05 AM

Fix spurious deletion of #endif

Harbormaster completed remote builds in B121009: Diff 368406.Aug 24 2021, 12:33 PM
ldionne added a comment.Aug 27 2021, 7:07 AM

Gentle ping - this should be easy to review.

mstorsjo accepted this revision.Aug 27 2021, 10:10 AM
mstorsjo added a subscriber: mstorsjo.

LGTM, once we can require Clang 13 (as support this attribute was added only there, right?) - and we can require that IIRC once Clang 14 is released?

ldionne updated this revision to Diff 403392.Jan 26 2022, 1:22 PM

Rebase onto main.

smeenai accepted this revision.Jan 26 2022, 2:20 PM

LGTM as well, thanks for cleaning this up!

Harbormaster completed remote builds in B145842: Diff 403392.Jan 26 2022, 4:54 PM
ldionne updated this revision to Diff 405328.Feb 2 2022, 10:00 AM

Rebase just to trigger CI. I will ship this if CI is happy.

ldionne accepted this revision as: Restricted Project.Feb 2 2022, 10:00 AM
This revision is now accepted and ready to land.Feb 2 2022, 10:00 AM
ldionne added a parent revision: D118831: [libc++] Bump minimum compiler requirements.Feb 2 2022, 10:32 AM
Harbormaster completed remote builds in B147180: Diff 405328.Feb 2 2022, 12:07 PM
ldionne updated this revision to Diff 414364.Mar 10 2022, 6:07 AM

Rebase onto main -- this should be ready to land now that we have bumped our compiler support window.

Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2022, 6:07 AM
Harbormaster completed remote builds in B153553: Diff 414364.Mar 10 2022, 9:44 AM
Closed by commit rGa805a15b287f: [libc++] Remove workaround for missing declarations on Windows store apps (authored by ldionne). · Explain WhyMar 11 2022, 6:09 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rGa805a15b287f: [libc++] Remove workaround for missing declarations on Windows store apps.

Revision Contents

PathSize
libcxx/
include/
10 lines
2 lines

Diff 368406

libcxx/include/__config

Show First 20 Lines • Show All 291 Lines • ▼ Show 20 Lines
# endif # endif
# if (defined(_M_AMD64) || defined(__x86_64__)) || (defined(_M_ARM) || defined(__arm__)) # if (defined(_M_AMD64) || defined(__x86_64__)) || (defined(_M_ARM) || defined(__arm__))
# define _LIBCPP_HAS_BITSCAN64 # define _LIBCPP_HAS_BITSCAN64
# endif # endif
# define _LIBCPP_HAS_OPEN_WITH_WCHAR # define _LIBCPP_HAS_OPEN_WITH_WCHAR
# if defined(_LIBCPP_MSVCRT) # if defined(_LIBCPP_MSVCRT)
# define _LIBCPP_HAS_QUICK_EXIT # define _LIBCPP_HAS_QUICK_EXIT
# endif # endif
// Some CRT APIs are unavailable to store apps
# if defined(WINAPI_FAMILY)
# include <winapifamily.h>
# if !WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP) && \
(!defined(WINAPI_PARTITION_SYSTEM) || \
!WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_SYSTEM))
# define _LIBCPP_WINDOWS_STORE_APP
# endif
# endif
#endif // defined(_WIN32) #endif // defined(_WIN32)
#ifdef __sun__ #ifdef __sun__
# include <sys/isa_defs.h> # include <sys/isa_defs.h>
# ifdef _LITTLE_ENDIAN # ifdef _LITTLE_ENDIAN
# define _LIBCPP_LITTLE_ENDIAN # define _LIBCPP_LITTLE_ENDIAN
# else # else
# define _LIBCPP_BIG_ENDIAN # define _LIBCPP_BIG_ENDIAN
▲ Show 20 Lines • Show All 1,134 Lines • Show Last 20 Lines

libcxx/include/cstdlib

Show First 20 Lines • Show All 123 Lines • ▼ Show 20 Lines
using ::calloc _LIBCPP_USING_IF_EXISTS; using ::calloc _LIBCPP_USING_IF_EXISTS;
using ::free _LIBCPP_USING_IF_EXISTS; using ::free _LIBCPP_USING_IF_EXISTS;
using ::malloc _LIBCPP_USING_IF_EXISTS; using ::malloc _LIBCPP_USING_IF_EXISTS;
using ::realloc _LIBCPP_USING_IF_EXISTS; using ::realloc _LIBCPP_USING_IF_EXISTS;
using ::abort _LIBCPP_USING_IF_EXISTS; using ::abort _LIBCPP_USING_IF_EXISTS;
using ::atexit _LIBCPP_USING_IF_EXISTS; using ::atexit _LIBCPP_USING_IF_EXISTS;
using ::exit _LIBCPP_USING_IF_EXISTS; using ::exit _LIBCPP_USING_IF_EXISTS;
using ::_Exit _LIBCPP_USING_IF_EXISTS; using ::_Exit _LIBCPP_USING_IF_EXISTS;
#ifndef _LIBCPP_WINDOWS_STORE_APP
using ::getenv _LIBCPP_USING_IF_EXISTS; using ::getenv _LIBCPP_USING_IF_EXISTS;
using ::system _LIBCPP_USING_IF_EXISTS; using ::system _LIBCPP_USING_IF_EXISTS;
#endif
using ::bsearch _LIBCPP_USING_IF_EXISTS; using ::bsearch _LIBCPP_USING_IF_EXISTS;
using ::qsort _LIBCPP_USING_IF_EXISTS; using ::qsort _LIBCPP_USING_IF_EXISTS;
using ::abs _LIBCPP_USING_IF_EXISTS; using ::abs _LIBCPP_USING_IF_EXISTS;
using ::labs _LIBCPP_USING_IF_EXISTS; using ::labs _LIBCPP_USING_IF_EXISTS;
#ifndef _LIBCPP_HAS_NO_LONG_LONG #ifndef _LIBCPP_HAS_NO_LONG_LONG
using ::llabs _LIBCPP_USING_IF_EXISTS; using ::llabs _LIBCPP_USING_IF_EXISTS;
#endif // _LIBCPP_HAS_NO_LONG_LONG #endif // _LIBCPP_HAS_NO_LONG_LONG
using ::div _LIBCPP_USING_IF_EXISTS; using ::div _LIBCPP_USING_IF_EXISTS;
Show All 20 Lines