Adds atoi, atol, atoll, strtol, strtoll, strtoul, and strtoull to the
list of entrypoints for Windows and aarch64 linux, as well as moving
them out of the LLVM_LIBC_FULL_BUILD condition for x86_64 linux.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
We should make all configs uniform. So, can we move these functions to the default config for x86_64 and aarch64 also?
Comment Actions
added the functions to aarch64, moved them out of the full build condition on x86_64, and updated the commit message.
Comment Actions
fix issues that came up in testing
The issues are as follows:
- Failure to build with FULL_BUILD off, due to the stdlib source not being included
- The string conversion tests not being run with FULL_BUILD off
- The atoi, atol, and atoll tests not being run at all (no CMake rule)
- A few typos found in the atol and atoll tests.
Comment Actions
Accepting but ideally we should separate concerns - the typos and missing CMake targets part should have been done in a separate patch.
Comment Actions
I will split patches like this in the future. For this patch I have run the tests on an aarch64 host, and they passed, so I will run one last check and then submit it.