Page MenuHomePhabricator

[MLIR][SCF] Parenthesize multiple return types in scf.execute_region asm op
ClosedPublic

Authored by mortbopet on Aug 19 2021, 12:39 PM.

Details

Summary

Previously, ExecuteRegionOps with multiple return values would fail a round-trip test due to missing parenthesis around the types.

Diff Detail

Event Timeline

mortbopet created this revision.Aug 19 2021, 12:39 PM
mortbopet requested review of this revision.Aug 19 2021, 12:39 PM
rriddle added inline comments.Aug 19 2021, 12:46 PM
mlir/lib/Dialect/SCF/SCF.cpp
118–121

^ That should do the same.

[MLIR][SCF] Use printOptionalArrowTypeList

rriddle accepted this revision.Aug 19 2021, 1:10 PM
rriddle added inline comments.
mlir/test/Dialect/SCF/ops.mlir
295–297

Are these lines necessary for the test? I'd drop them. This test should just be about the trailing types.

This revision is now accepted and ready to land.Aug 19 2021, 1:10 PM
mortbopet updated this revision to Diff 367600.Aug 19 2021, 1:18 PM
mortbopet marked an inline comment as done.

Remove redundant check lines

This revision was landed with ongoing or failed builds.Aug 19 2021, 1:33 PM
This revision was automatically updated to reflect the committed changes.