Page MenuHomePhabricator

mortbopet (Morten Borup Petersen)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2021, 7:56 AM (83 w, 13 h)

Recent Activity

Jul 25 2022

mortbopet removed reviewers for D130007: [mlir] Expose value replacement methods through CAPI & Python bindings: stellaraccident, jdd.

Looking into this, it seems more difficult than initially thought to expose low-level operations to perform value replacement through the CAPI. We'd expect getUses to return OpOperands (by inheritance, IrOperand) which in turn is what we would call replace on.
Main pain points which i see here are:

  1. OpOperand is heavily encapsulated to protect how and who can construct an operand. https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/IR/Value.h#L265
  2. By the above, there's no immediate way that we can roundtrip the value through CAPI, which would require that an OpOperand can be constructed statically through an opaque pointer.
Jul 25 2022, 2:29 AM · Restricted Project, Restricted Project

Jul 19 2022

mortbopet added reviewers for D130007: [mlir] Expose value replacement methods through CAPI & Python bindings: stellaraccident, jdd.
Jul 19 2022, 12:26 AM · Restricted Project, Restricted Project

Jul 18 2022

mortbopet requested review of D130007: [mlir] Expose value replacement methods through CAPI & Python bindings.
Jul 18 2022, 6:52 AM · Restricted Project, Restricted Project

Jan 4 2022

mortbopet added a comment to D114945: [mlir] Add maximum SSA form transformation pass.

@rriddle do you have anything else you'd like too see done for the PR?

Jan 4 2022, 12:25 AM · Restricted Project

Dec 13 2021

mortbopet updated the diff for D114945: [mlir] Add maximum SSA form transformation pass.

Address review comments.

Dec 13 2021, 1:03 AM · Restricted Project

Dec 7 2021

mortbopet updated the diff for D114945: [mlir] Add maximum SSA form transformation pass.

reduce number of times each block is visited

Dec 7 2021, 8:09 AM · Restricted Project
mortbopet updated the diff for D114945: [mlir] Add maximum SSA form transformation pass.

address review comments

Dec 7 2021, 7:14 AM · Restricted Project
mortbopet updated the diff for D114945: [mlir] Add maximum SSA form transformation pass.

add missing early_inc_range and simplify tests

Dec 7 2021, 7:08 AM · Restricted Project

Dec 6 2021

mortbopet updated the diff for D114945: [mlir] Add maximum SSA form transformation pass.

address review comments.

Dec 6 2021, 9:57 AM · Restricted Project
mortbopet added inline comments to D114945: [mlir] Add maximum SSA form transformation pass.
Dec 6 2021, 9:56 AM · Restricted Project
mortbopet updated the diff for D114945: [mlir] Add maximum SSA form transformation pass.

Rework the conversion pass into a transform utility. In doing so, also define a test pass for the filtered case. The transformation utility now takes a lambda to specify a value filter. The user-exposed pass convert-to-max-ssa no longer takes any arguments. For my own use-case, this is sufficient, since i'll be using the SSA maximization utility with a filtered type as a precondition for another conversion pass.

Dec 6 2021, 12:53 AM · Restricted Project

Dec 5 2021

mortbopet updated the diff for D114945: [mlir] Add maximum SSA form transformation pass.

address review comments

Dec 5 2021, 11:57 PM · Restricted Project

Dec 2 2021

mortbopet added inline comments to D114945: [mlir] Add maximum SSA form transformation pass.
Dec 2 2021, 11:40 PM · Restricted Project
mortbopet updated the diff for D114945: [mlir] Add maximum SSA form transformation pass.

update include

Dec 2 2021, 11:14 AM · Restricted Project
mortbopet added inline comments to D114945: [mlir] Add maximum SSA form transformation pass.
Dec 2 2021, 11:13 AM · Restricted Project
mortbopet updated the diff for D114945: [mlir] Add maximum SSA form transformation pass.

argument and control flow mappings should be stored for any value

Dec 2 2021, 10:28 AM · Restricted Project
mortbopet added a reviewer for D114945: [mlir] Add maximum SSA form transformation pass: stephenneuendorffer.
Dec 2 2021, 6:01 AM · Restricted Project
mortbopet updated the diff for D114945: [mlir] Add maximum SSA form transformation pass.

missing }

Dec 2 2021, 5:33 AM · Restricted Project
mortbopet abandoned D114948: Missing }.
Dec 2 2021, 5:32 AM · Restricted Project
mortbopet requested review of D114948: Missing }.
Dec 2 2021, 5:30 AM · Restricted Project
mortbopet updated the diff for D114945: [mlir] Add maximum SSA form transformation pass.

incorrect namespace

Dec 2 2021, 4:53 AM · Restricted Project
mortbopet requested review of D114945: [mlir] Add maximum SSA form transformation pass.
Dec 2 2021, 4:51 AM · Restricted Project

Sep 21 2021

mortbopet committed rG032cb1650fe6: [MLIR][SCF] Add for-to-while loop transformation pass (authored by mortbopet).
[MLIR][SCF] Add for-to-while loop transformation pass
Sep 21 2021, 1:10 AM

Sep 20 2021

mortbopet abandoned D110087: rebase to main.
Sep 20 2021, 11:03 AM · Restricted Project
mortbopet requested review of D110087: rebase to main.
Sep 20 2021, 11:02 AM · Restricted Project
mortbopet added a comment to D108454: [MLIR][SCF] Add for-to-while loop transformation pass.

I think you had tested this on an old revision but it failed CI at HEAD, can you rebase and fix the test before recommitting?

Sep 20 2021, 10:38 AM · Restricted Project
mortbopet committed rG644b55d57ec7: [MLIR][SCF] Add for-to-while loop transformation pass (authored by mortbopet).
[MLIR][SCF] Add for-to-while loop transformation pass
Sep 20 2021, 8:58 AM
mortbopet closed D108454: [MLIR][SCF] Add for-to-while loop transformation pass.
Sep 20 2021, 8:58 AM · Restricted Project

Sep 18 2021

mortbopet updated the diff for D108454: [MLIR][SCF] Add for-to-while loop transformation pass.

Address review comments

Sep 18 2021, 3:25 AM · Restricted Project

Sep 17 2021

mortbopet updated the diff for D108454: [MLIR][SCF] Add for-to-while loop transformation pass.

mising newline

Sep 17 2021, 9:33 AM · Restricted Project
mortbopet updated the summary of D108454: [MLIR][SCF] Add for-to-while loop transformation pass.
Sep 17 2021, 7:05 AM · Restricted Project
mortbopet updated the diff for D108454: [MLIR][SCF] Add for-to-while loop transformation pass.

I've added a rationale to the PR summary.

Sep 17 2021, 7:05 AM · Restricted Project
mortbopet updated the diff for D108454: [MLIR][SCF] Add for-to-while loop transformation pass.

scf.execute_region ops are no longer necessary.

Sep 17 2021, 6:26 AM · Restricted Project
mortbopet updated the diff for D108454: [MLIR][SCF] Add for-to-while loop transformation pass.
  • Moved induction variable incrementation to start of while body
  • updated tests
Sep 17 2021, 5:26 AM · Restricted Project

Aug 23 2021

mortbopet added a reviewer for D108454: [MLIR][SCF] Add for-to-while loop transformation pass: stephenneuendorffer.
Aug 23 2021, 9:54 AM · Restricted Project
mortbopet added reviewers for D108454: [MLIR][SCF] Add for-to-while loop transformation pass: pifon2a, wsmoses.
Aug 23 2021, 12:52 AM · Restricted Project

Aug 20 2021

mortbopet updated the diff for D108454: [MLIR][SCF] Add for-to-while loop transformation pass.

Fix clang-tidy nits

Aug 20 2021, 3:28 AM · Restricted Project
mortbopet requested review of D108454: [MLIR][SCF] Add for-to-while loop transformation pass.
Aug 20 2021, 2:52 AM · Restricted Project

Aug 19 2021

mortbopet committed rG6c1436a9b03e: [MLIR][SCF] Parenthesize multiple return types in scf.execute_region asm op (authored by mortbopet).
[MLIR][SCF] Parenthesize multiple return types in scf.execute_region asm op
Aug 19 2021, 1:33 PM
mortbopet closed D108402: [MLIR][SCF] Parenthesize multiple return types in scf.execute_region asm op.
Aug 19 2021, 1:33 PM · Restricted Project
mortbopet updated the diff for D108402: [MLIR][SCF] Parenthesize multiple return types in scf.execute_region asm op.

Remove redundant check lines

Aug 19 2021, 1:18 PM · Restricted Project
mortbopet updated the diff for D108402: [MLIR][SCF] Parenthesize multiple return types in scf.execute_region asm op.

[MLIR][SCF] Use printOptionalArrowTypeList

Aug 19 2021, 12:52 PM · Restricted Project
mortbopet requested review of D108402: [MLIR][SCF] Parenthesize multiple return types in scf.execute_region asm op.
Aug 19 2021, 12:39 PM · Restricted Project