This is an archive of the discontinued LLVM Phabricator instance.

Could you please also add into HWAddressSanitizer/stack-safety-analysis.ll to check this default behavior.
; RUN: opt -hwasan -hwasan-generate-tags-with-calls -S < %s | FileCheck %s --check-prefixes=SAFETY

This revision is now accepted and ready to land.Aug 19 2021, 11:42 AM

Could you please also add into HWAddressSanitizer/stack-safety-analysis.ll to check this default behavior.

Yes, please!

LGTM

test that stack safety defaults on.

This revision was landed with ongoing or failed builds.Aug 19 2021, 1:11 PM

Closed by commit rG73323c6eaa22: [hwasan] re-enable stack safety by default. (authored by fmayer). · Explain Why

This revision was automatically updated to reflect the committed changes.

fmayer added a commit: rG73323c6eaa22: [hwasan] re-enable stack safety by default..

Harbormaster completed remote builds in B120411: Diff 367598.Aug 19 2021, 1:43 PM

GitHub <noreply@github.com> mentioned this in rG51fbab134560: [asan] Enable StackSafetyAnalysis by default.Mon, Jan 15, 1:28 PM

MaskRay mentioned this in rG7740565f56ce: [asan] Enable StackSafetyAnalysis by default.Mon, Jan 15, 1:32 PM

Revision Contents

Path

Size

llvm/

lib/

Transforms/

Instrumentation/

HWAddressSanitizer.cpp

2 lines

test/

Instrumentation/

HWAddressSanitizer/

stack-safety-analysis.ll

1 line

Diff 367599

llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp

Show First 20 Lines • Show All 109 Lines • ▼ Show 20 Lines	ClRecover("hwasan-recover",
cl::desc("Enable recovery mode (continue-after-error)."),		cl::desc("Enable recovery mode (continue-after-error)."),
cl::Hidden, cl::init(false));		cl::Hidden, cl::init(false));

static cl::opt<bool> ClInstrumentStack("hwasan-instrument-stack",		static cl::opt<bool> ClInstrumentStack("hwasan-instrument-stack",
cl::desc("instrument stack (allocas)"),		cl::desc("instrument stack (allocas)"),
cl::Hidden, cl::init(true));		cl::Hidden, cl::init(true));

static cl::opt<bool>		static cl::opt<bool>
ClUseStackSafety("hwasan-use-stack-safety", cl::Hidden, cl::init(false),		ClUseStackSafety("hwasan-use-stack-safety", cl::Hidden, cl::init(true),
cl::Hidden, cl::desc("Use Stack Safety analysis results"),		cl::Hidden, cl::desc("Use Stack Safety analysis results"),
cl::Optional);		cl::Optional);

static cl::opt<bool>		static cl::opt<bool>
ClUseAfterScope("hwasan-use-after-scope",		ClUseAfterScope("hwasan-use-after-scope",
cl::desc("detect use after scope within function"),		cl::desc("detect use after scope within function"),
cl::Hidden, cl::init(false));		cl::Hidden, cl::init(false));

▲ Show 20 Lines • Show All 1,676 Lines • Show Last 20 Lines

llvm/test/Instrumentation/HWAddressSanitizer/stack-safety-analysis.ll

	; RUN: opt -hwasan -hwasan-use-stack-safety=1 -hwasan-generate-tags-with-calls -S < %s \| FileCheck %s --check-prefixes=SAFETY			; RUN: opt -hwasan -hwasan-use-stack-safety=1 -hwasan-generate-tags-with-calls -S < %s \| FileCheck %s --check-prefixes=SAFETY
	; RUN: opt -hwasan -hwasan-use-stack-safety=0 -hwasan-generate-tags-with-calls -S < %s \| FileCheck %s --check-prefixes=NOSAFETY			; RUN: opt -hwasan -hwasan-use-stack-safety=0 -hwasan-generate-tags-with-calls -S < %s \| FileCheck %s --check-prefixes=NOSAFETY
				; RUN: opt -hwasan -hwasan-generate-tags-with-calls -S < %s \| FileCheck %s --check-prefixes=SAFETY

	target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"			target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
	target triple = "aarch64-unknown-linux-gnu"			target triple = "aarch64-unknown-linux-gnu"

	; Check a safe alloca to ensure it does not get a tag.			; Check a safe alloca to ensure it does not get a tag.
	define i32 @test_load(i32* %a) sanitize_hwaddress {			define i32 @test_load(i32* %a) sanitize_hwaddress {
	entry:			entry:
	; NOSAFETY: call {{.*}}__hwasan_generate_tag			; NOSAFETY: call {{.*}}__hwasan_generate_tag
	Show All 32 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[hwasan] re-enable stack safety by default.ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 367599

llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp

llvm/test/Instrumentation/HWAddressSanitizer/stack-safety-analysis.ll

[hwasan] re-enable stack safety by default.
ClosedPublic