This is an archive of the discontinued LLVM Phabricator instance.

Wrap MLIR addAffineForOpDomain warning with LLVM_DEBUG
ClosedPublic

Authored by TharinduRusira on Aug 18 2021, 4:16 PM.

Details

Summary

Current warning message in method addAffineForOpDomain of mlir/lib/Analysis/AffineStructures.cpp is being printed to the stdout/stderr.
This patch redirects the warning with LLVM_DEBUG following standard llvm practice.

Diff Detail

Event Timeline

TharinduRusira created this revision.Aug 18 2021, 4:16 PM
TharinduRusira requested review of this revision.Aug 18 2021, 4:16 PM

First patch had changes made to an unrelated file. This update cleans the original submission.

bondhugula added a comment.EditedAug 21 2021, 7:03 AM

Your patch has no context? Did you use arc diff? Please also update the commit title and summary to reflect which part of codebase/method/library this is about. For eg.

Wrap MLIR addAffineForOpDomain warning with LLVM_DEBUG
bondhugula requested changes to this revision.Aug 27 2021, 11:14 PM
This revision now requires changes to proceed.Aug 27 2021, 11:14 PM
TharinduRusira retitled this revision from LLVM_DEBUG wrapper for warning message to Wrap MLIR addAffineForOpDomain warning with LLVM_DEBUG.
TharinduRusira edited the summary of this revision. (Show Details)

Updating previously submitted patch with arch diff

Applied the changes on a git pull so that this version of the revision is compatible with the latest LLVM HEAD.

bondhugula accepted this revision.Sep 2 2021, 11:24 AM
This revision is now accepted and ready to land.Sep 2 2021, 11:24 AM

I don't have commit access. Could someone commit this patch?

This revision was automatically updated to reflect the committed changes.