StackLifetime: Remove asserts for multiple lifetime intrinsics.

[pcc]

Summary

According to the langref, it is valid to have multiple consecutive
lifetime start or end intrinsics on the same object.

For llvm.lifetime.start:
"If ptr [...] is a stack object that is already alive, it simply
fills all bytes of the object with poison."

For llvm.lifetime.end:
"Calling llvm.lifetime.end on an already dead alloca is no-op."

However, we currently fail an assertion in such cases. I've observed
the assertion failure when the loop vectorization pass duplicates
the intrinsic.

We can conservatively handle these intrinsics by ignoring all but
the first one, which can be implemented by removing the assertions.

[eugenis]

Please update test/Analysis/StackSafetyAnalysis/lifetime.ll instead, and it would be good to extend it with testcases for liveness between two start and two end calls.

[pcc]

Test this in test/Analysis/StackSafetyAnalysis/lifetime.ll instead

[eugenis]

LGTM

llvm/lib/Analysis/StackLifetime.cpp

for (auto IT : BlockLiveness) {
     }
 
     for (auto &It : BBMarkers[BB]) {
       unsigned InstNo = It.first;
       bool IsStart = It.second.IsStart;
       unsigned AllocaNo = It.second.AllocaNo;
 
       if (IsStart) {
-        assert(!Started.test(AllocaNo) || Start[AllocaNo] == BBStart);
         if (!Started.test(AllocaNo)) {
           Started.set(AllocaNo);
           Ended.reset(AllocaNo);
           Start[AllocaNo] = InstNo;
         }
       } else {
-        assert(!Ended.test(AllocaNo));
         if (Started.test(AllocaNo)) {
           LiveRanges[AllocaNo].addRange(Start[AllocaNo], InstNo);
           Started.reset(AllocaNo);
         }
         Ended.set(AllocaNo);
       }
     }
 

llvm/test/Instrumentation/HWAddressSanitizer/use-after-scope.ll

3:
   call void @use(i8* nonnull %1) #2
   call void @llvm.lifetime.end.p0i8(i64 1, i8* nonnull %1)
   ret i32 0
 
 4:
   ret i32 0
 }
 
+define dso_local i32 @multiple_start_end() local_unnamed_addr sanitize_hwaddress {
+; SCOPE-LABEL: @multiple_start_end(
+; SCOPE: call void @__hwasan_tag_memory
+; SCOPE: call void @use
+; SCOPE: call void @__hwasan_tag_memory
+  %1 = alloca i8, align 1
+  call void @llvm.lifetime.start.p0i8(i64 1, i8* nonnull %1)
+  call void @llvm.lifetime.start.p0i8(i64 1, i8* nonnull %1)
+  call void @use(i8* nonnull %1)
+  call void @llvm.lifetime.end.p0i8(i64 1, i8* nonnull %1)
+  call void @llvm.lifetime.end.p0i8(i64 1, i8* nonnull %1)
+  ret i32 0
+}
+
 declare dso_local i1 @cond(...) local_unnamed_addr
 
 declare dso_local void @use(i8*) local_unnamed_addr
 
 ; Function Attrs: argmemonly mustprogress nofree nosync nounwind willreturn
 declare void @llvm.lifetime.start.p0i8(i64 immarg, i8* nocapture)
 
 ; Function Attrs: argmemonly mustprogress nofree nosync nounwind willreturn
 declare void @llvm.lifetime.end.p0i8(i64 immarg, i8* nocapture)