Page MenuHomePhabricator

AMDGPU: Remove hacky attribute deduction from AMDGPUAttributor

Authored by arsenm on Aug 12 2021, 9:50 AM.



amdgpu-calls and amdgpu-stack-objects don't really belong as
attributes, and are currently a hacky way of passing an analysis into
the DAG. These don't really belong in the IR, and don't really fit in
with the other attributes. Remove these to facilitate inverting the

I don't exactly understand the indirect call test changes. These tests
are using calls which are trivially replacable with a direct call, so
I'm not sure what the point is.

Diff Detail

Event Timeline

arsenm created this revision.Aug 12 2021, 9:50 AM
arsenm requested review of this revision.Aug 12 2021, 9:50 AM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: wdng. · View Herald Transcript
kuter accepted this revision.Aug 17 2021, 11:56 AM


This revision is now accepted and ready to land.Aug 17 2021, 11:56 AM