Page MenuHomePhabricator

[OpenMP][NFC] Eliminate CopyMember from targetDataEnd
ClosedPublic

Authored by jdenny on Aug 11 2021, 1:02 PM.

Details

Summary

This patch is based on comments in D105990. It is NFC according to
the following observations:

  1. CopyMember is computed as !IsHostPtr && IsLast.
  2. DelEntry is true only if IsLast is true.

We apply those observations in order:

if ((DelEntry || Always || CopyMember) && !IsHostPtr)

if ((DelEntry || Always || IsLast) && !IsHostPtr)

if ((Always || IsLast) && !IsHostPtr)

Diff Detail

Event Timeline

jdenny created this revision.Aug 11 2021, 1:02 PM
jdenny requested review of this revision.Aug 11 2021, 1:02 PM
grokos accepted this revision.Aug 27 2021, 9:17 AM

DelEntry is true only if IsLast is true.

Good observation, simplifies the condition even further! LGTM.

This revision is now accepted and ready to land.Aug 27 2021, 9:17 AM
This revision was automatically updated to reflect the committed changes.