This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [gdb-server] Add tests for more vFile packets
ClosedPublic

Authored by mgorny on Aug 10 2021, 5:51 AM.

Diff Detail

Event Timeline

mgorny requested review of this revision.Aug 10 2021, 5:51 AM
mgorny created this revision.
labath accepted this revision.Sep 7 2021, 4:50 AM

Instead of the tempfile thingies I'd probably just use fixed files names in the build directory -- it's specific to a single test, automatically cleaned on each run and it's where all of our other "temporary" files end up

This revision is now accepted and ready to land.Sep 7 2021, 4:50 AM
mgorny added a comment.Sep 8 2021, 1:46 AM

Instead of the tempfile thingies I'd probably just use fixed files names in the build directory -- it's specific to a single test, automatically cleaned on each run and it's where all of our other "temporary" files end up

Done that. I'll do one more test run, then push.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2021, 2:01 AM