This is an archive of the discontinued LLVM Phabricator instance.

Differential D107238

[mlir] Remove invalid DeallocOpLowering pattern insertion
ClosedPublic

Authored by Hardcode84 on Aug 1 2021, 4:53 AM.

Details

Reviewers
ftynse
Commits
rG00a756d3f6e9: [mlir] Remove invalid DeallocOpLowering pattern insertion
Summary

It is inserted later under then condition.

Diff Detail

Event Timeline

Hardcode84 created this revision.Aug 1 2021, 4:53 AM
Herald added a reviewer: ftynse. · View Herald TranscriptAug 1 2021, 4:53 AM
Herald added subscribers: Chia-hungDuan, dcaballe, cota and 17 others. · View Herald Transcript
Hardcode84 requested review of this revision.Aug 1 2021, 4:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2021, 4:53 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B117355: Diff 363340.Aug 1 2021, 5:25 AM
ftynse accepted this revision.Aug 2 2021, 12:25 AM
This revision is now accepted and ready to land.Aug 2 2021, 12:25 AM
Closed by commit rG00a756d3f6e9: [mlir] Remove invalid DeallocOpLowering pattern insertion (authored by Hardcode84). · Explain WhyAug 2 2021, 1:28 AM
This revision was automatically updated to reflect the committed changes.
Hardcode84 added a commit: rG00a756d3f6e9: [mlir] Remove invalid DeallocOpLowering pattern insertion.

Revision Contents

PathSize
mlir/
lib/
Conversion/
MemRefToLLVM/
1 line

Diff 363393

mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp

Show First 20 Lines • Show All 1,542 Lines • ▼ Show 20 Lines
void mlir::populateMemRefToLLVMConversionPatterns(LLVMTypeConverter &converter, void mlir::populateMemRefToLLVMConversionPatterns(LLVMTypeConverter &converter,
RewritePatternSet &patterns) { RewritePatternSet &patterns) {
// clang-format off // clang-format off
patterns.add< patterns.add<
AllocaOpLowering, AllocaOpLowering,
AllocaScopeOpLowering, AllocaScopeOpLowering,
AssumeAlignmentOpLowering, AssumeAlignmentOpLowering,
DimOpLowering, DimOpLowering,
DeallocOpLowering,
GlobalMemrefOpLowering, GlobalMemrefOpLowering,
GetGlobalMemrefOpLowering, GetGlobalMemrefOpLowering,
LoadOpLowering, LoadOpLowering,
MemRefCastOpLowering, MemRefCastOpLowering,
MemRefCopyOpLowering, MemRefCopyOpLowering,
MemRefReinterpretCastOpLowering, MemRefReinterpretCastOpLowering,
MemRefReshapeOpLowering, MemRefReshapeOpLowering,
PrefetchOpLowering, PrefetchOpLowering,
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines