Page MenuHomePhabricator

[SLP]Fix an assertion for the size of user nodes.
ClosedPublic

Authored by ABataev on Jul 29 2021, 7:52 AM.

Details

Summary

For the nodes with reused scalars the user may be not only of the size
of the final shuffle but also of the size of the scalars themselves,
need to check for this. It is safe to just modify the check here, since
the order of the scalars themselves is preserved, only indeces of the
reused scalars is changed. So, the users with the same size as the
number of scalars in the node, will not be affected, they still will get
the operands in the required order.

Reported by @mstorsjo in D105020.

Diff Detail

Event Timeline

ABataev created this revision.Jul 29 2021, 7:52 AM
ABataev requested review of this revision.Jul 29 2021, 7:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2021, 7:52 AM
RKSimon accepted this revision.Jul 30 2021, 5:44 AM

LGTM

This revision is now accepted and ready to land.Jul 30 2021, 5:44 AM
This revision was landed with ongoing or failed builds.Jul 30 2021, 5:47 AM
This revision was automatically updated to reflect the committed changes.