This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][GlobalISel] Improve legalization for odd-type G_LOAD
ClosedPublic

Authored by paquette on Jul 28 2021, 4:09 PM.

Details

Summary

Swap the order of widening so that we widen to the next power-of-2 first when legalizing G_LOAD.

Also, provide a minimum type for the power of 2 to disallow s2 + s1. Clamping ought to disallow s2 and s1, but I think it's better to be explicit about the expected minimum size.

We probably need a similar change for G_STORE, but it seems to be a bit more finnicky. So, let's just handle G_LOAD for now.

Diff Detail

Event Timeline

paquette created this revision.Jul 28 2021, 4:09 PM
paquette requested review of this revision.Jul 28 2021, 4:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2021, 4:09 PM
aemerson accepted this revision.Jul 28 2021, 4:42 PM
This revision is now accepted and ready to land.Jul 28 2021, 4:42 PM
This revision was landed with ongoing or failed builds.Jul 28 2021, 5:20 PM
This revision was automatically updated to reflect the committed changes.