Page MenuHomePhabricator

[IRSim][IROutliner] Detecting Similar Phi Nodes and Outlining
Needs ReviewPublic

Authored by AndrewLitteken on Jul 28 2021, 1:13 PM.

Details

Reviewers
paquette
Summary

We use the same similarity scheme we used for branch instructions for phi nodes, and allow them to be outlined. There is not a lot of special handling needed for these phi nodes when outlining, as they simply act as outputs. The code extractor does not currently allow for non entry blocks within the extracted region to have predecessors, so there are not conflicts to handle with respect to predecessors no longer contained in the function.

Diff Detail

Event Timeline

AndrewLitteken created this revision.Jul 28 2021, 1:13 PM
AndrewLitteken requested review of this revision.Jul 28 2021, 1:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2021, 1:13 PM

Updating to handle changes from previous commits, more thorough testing, and bug fixes for outlining PHINodes.

AndrewLitteken added inline comments.Sep 16 2021, 9:41 AM
llvm/lib/Transforms/IPO/IROutliner.cpp
185

this needs Doxygen comments