This is an archive of the discontinued LLVM Phabricator instance.

[mlir] run the verifier before translating a module
ClosedPublic

Authored by ftynse on Jul 28 2021, 1:23 AM.

Details

Summary

In translation from MLIR to another IR, run the MLIR verifier on the parsed
module to ensure only valid modules are given to the translation. Previously,
we would send any module that could be parsed to the translation, including
semantically invalid modules, leading to surprising errors or lack thereof down
the pipeline.

Depends On D106937

Diff Detail

Event Timeline

ftynse created this revision.Jul 28 2021, 1:23 AM
ftynse requested review of this revision.Jul 28 2021, 1:23 AM
mehdi_amini accepted this revision.Jul 28 2021, 9:13 AM
This revision is now accepted and ready to land.Jul 28 2021, 9:13 AM
This revision was automatically updated to reflect the committed changes.