Page MenuHomePhabricator

Revert "sanitizer_common: split LibIgnore into fast/slow paths"
ClosedPublic

Authored by dvyukov on Jul 27 2021, 2:11 AM.

Details

Summary

This reverts commit 1e1f7520279c93a59fa6511028ff40412065985e.

It breaks ignore_noninstrumented_modules=1.
Somehow we did not have any portable tests for this mode before
(only Darwin tests). Add a portable test as well.

Moreover, I think I was too fast uninlining all LibIgnore checks.
For Java, Darwin and OpenMP LibIgnore is always enabled,
so it makes sense to leave it as it was before.

Diff Detail

Event Timeline

dvyukov created this revision.Jul 27 2021, 2:11 AM
dvyukov requested review of this revision.Jul 27 2021, 2:11 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: Restricted Project, sstefan1. · View Herald Transcript
melver accepted this revision.Jul 27 2021, 2:40 AM
This revision is now accepted and ready to land.Jul 27 2021, 2:40 AM
This revision was landed with ongoing or failed builds.Jul 27 2021, 2:43 AM
This revision was automatically updated to reflect the committed changes.