Page MenuHomePhabricator

[SimplifyCFG] Don't speculatively execute BB[s] if they are predictably not taken
ClosedPublic

Authored by lebedev.ri on Jul 23 2021, 3:05 PM.

Diff Detail

Event Timeline

lebedev.ri created this revision.Jul 23 2021, 3:05 PM
lebedev.ri requested review of this revision.Jul 23 2021, 3:05 PM
lebedev.ri retitled this revision from [SimplifyCFG] Don't speculatively execute BB[s] if it's predictably not taken to [SimplifyCFG] Don't speculatively execute BB[s] if they are predictably not taken.
spatel accepted this revision.Jul 25 2021, 2:04 PM

LGTM - as with the similar D106650, I think we could use 1-2 more tests with a metadata/branch prob just below getPredictableBranchThreshold(), so we verify that calculation works as expected.

This revision is now accepted and ready to land.Jul 25 2021, 2:04 PM

LGTM - as with the similar D106650, I think we could use 1-2 more tests with a metadata/branch prob just below getPredictableBranchThreshold(), so we verify that calculation works as expected.

Will do, thank you for the review!

This revision was landed with ongoing or failed builds.Jul 25 2021, 5:01 PM
This revision was automatically updated to reflect the committed changes.