This is an archive of the discontinued LLVM Phabricator instance.

[SLP]Fix costs calculations.
ClosedPublic

Authored by ABataev on Jul 22 2021, 11:17 AM.

Details

Summary

Need to fix several cost-related problems. The final type may be defined
incorrectly because of to early definition (we may end up with the wider
type), the CommonCost should not be redefined in ExtractElements
cost related calculations and the shuffle of the final insertelements
vectors should be calculated as a cost of single vector permutations
+ costs of two vector permutations for other n-1 incoming vectors.

Diff Detail

Event Timeline

ABataev created this revision.Jul 22 2021, 11:17 AM
ABataev requested review of this revision.Jul 22 2021, 11:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2021, 11:17 AM
ABataev added inline comments.Jul 22 2021, 11:19 AM
llvm/test/Transforms/SLPVectorizer/AArch64/PR38339.ll
6–16

This one and other cases in this test must be fixed once D106241 is landed but still it helps to reveal bugs.

ABataev updated this revision to Diff 361308.Jul 23 2021, 12:49 PM

Rebase + fixes

RKSimon accepted this revision.Jul 24 2021, 1:27 AM

LGTM

This revision is now accepted and ready to land.Jul 24 2021, 1:27 AM
This revision was landed with ongoing or failed builds.Jul 26 2021, 5:05 AM
This revision was automatically updated to reflect the committed changes.