This is an archive of the discontinued LLVM Phabricator instance.

Differential D106539

[mlir] Improve description of interface options
ClosedPublic

Authored by marbre on Jul 22 2021, 5:22 AM.

Details

Reviewers
mehdi_amini
rriddle
Commits
rG49d840c35c69: [mlir] Improve description of interface options

Diff Detail

Event Timeline

marbre created this revision.Jul 22 2021, 5:22 AM
Herald added subscribers: dcaballe, cota, teijeong and 14 others. · View Herald TranscriptJul 22 2021, 5:22 AM
marbre requested review of this revision.Jul 22 2021, 5:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2021, 5:22 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B115538: Diff 360774.Jul 22 2021, 6:05 AM
rriddle accepted this revision.Jul 22 2021, 10:13 AM
This revision is now accepted and ready to land.Jul 22 2021, 10:13 AM
Closed by commit rG49d840c35c69: [mlir] Improve description of interface options (authored by marbre). · Explain WhyJul 22 2021, 10:36 AM
This revision was automatically updated to reflect the committed changes.
marbre added a commit: rG49d840c35c69: [mlir] Improve description of interface options.

Revision Contents

PathSize
mlir/
tools/
mlir-tblgen/
22 lines

Diff 360877

mlir/tools/mlir-tblgen/OpInterfacesGen.cpp

Show First 20 Lines • Show All 538 Lines • ▼ Show 20 Linesbool InterfaceGenerator::emitInterfaceDocs() {
return false; return false;
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// GEN: Interface registration hooks // GEN: Interface registration hooks
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
namespace { namespace {
template <typename GeneratorT> struct InterfaceGenRegistration { template <typename GeneratorT>
InterfaceGenRegistration(StringRef genArg) struct InterfaceGenRegistration {
InterfaceGenRegistration(StringRef genArg, StringRef genDesc)
: genDeclArg(("gen-" + genArg + "-interface-decls").str()), : genDeclArg(("gen-" + genArg + "-interface-decls").str()),
genDefArg(("gen-" + genArg + "-interface-defs").str()), genDefArg(("gen-" + genArg + "-interface-defs").str()),
genDocArg(("gen-" + genArg + "-interface-docs").str()), genDocArg(("gen-" + genArg + "-interface-docs").str()),
genDecls(genDeclArg, "Generate interface declarations", genDeclDesc(("Generate " + genDesc + " interface declarations").str()),
genDefDesc(("Generate " + genDesc + " interface definitions").str()),
genDocDesc(("Generate " + genDesc + " interface documentation").str()),
genDecls(genDeclArg, genDeclDesc,
[](const llvm::RecordKeeper &records, raw_ostream &os) { [](const llvm::RecordKeeper &records, raw_ostream &os) {
return GeneratorT(records, os).emitInterfaceDecls(); return GeneratorT(records, os).emitInterfaceDecls();
}), }),
genDefs(genDefArg, "Generate interface definitions", genDefs(genDefArg, genDefDesc,
[](const llvm::RecordKeeper &records, raw_ostream &os) { [](const llvm::RecordKeeper &records, raw_ostream &os) {
return GeneratorT(records, os).emitInterfaceDefs(); return GeneratorT(records, os).emitInterfaceDefs();
}), }),
genDocs(genDocArg, "Generate interface documentation", genDocs(genDocArg, genDocDesc,
[](const llvm::RecordKeeper &records, raw_ostream &os) { [](const llvm::RecordKeeper &records, raw_ostream &os) {
return GeneratorT(records, os).emitInterfaceDocs(); return GeneratorT(records, os).emitInterfaceDocs();
}) {} }) {}
std::string genDeclArg, genDefArg, genDocArg; std::string genDeclArg, genDefArg, genDocArg;
std::string genDeclDesc, genDefDesc, genDocDesc;
mlir::GenRegistration genDecls, genDefs, genDocs; mlir::GenRegistration genDecls, genDefs, genDocs;
}; };
} // end anonymous namespace } // end anonymous namespace
static InterfaceGenRegistration<AttrInterfaceGenerator> attrGen("attr"); static InterfaceGenRegistration<AttrInterfaceGenerator> attrGen("attr",
static InterfaceGenRegistration<OpInterfaceGenerator> opGen("op"); "attribute");
static InterfaceGenRegistration<TypeInterfaceGenerator> typeGen("type"); static InterfaceGenRegistration<OpInterfaceGenerator> opGen("op", "op");
static InterfaceGenRegistration<TypeInterfaceGenerator> typeGen("type", "type");