This is an archive of the discontinued LLVM Phabricator instance.

Differential D106414

[DWP] Fix for Refactoring llvm-dwp in to a library
ClosedPublic

Authored by ayermolo on Jul 20 2021, 6:12 PM.

Details

Reviewers
dblaikie
Commits
rG51db2363243c: [DWP] Fix for Refactoring llvm-dwp in to a library
Summary

Fix build for https://reviews.llvm.org/D106198 when -DBUILD_SHARED_LIBS=ON. Test Plan:

Diff Detail

Event Timeline

ayermolo created this revision.Jul 20 2021, 6:12 PM
Herald added subscribers: hoy, modimo, wenlei, mgorny. · View Herald TranscriptJul 20 2021, 6:12 PM
ayermolo requested review of this revision.Jul 20 2021, 6:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2021, 6:12 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
dblaikie accepted this revision.Jul 20 2021, 6:14 PM

Sure, if that seems to do the trick

This revision is now accepted and ready to land.Jul 20 2021, 6:14 PM
ayermolo added a comment.Jul 20 2021, 6:15 PM
In D106414#2892211, @dblaikie wrote:

Sure, if that seems to do the trick

In my local build at least.

This revision was landed with ongoing or failed builds.Jul 20 2021, 6:17 PM
Closed by commit rG51db2363243c: [DWP] Fix for Refactoring llvm-dwp in to a library (authored by ayermolo). · Explain Why
This revision was automatically updated to reflect the committed changes.
ayermolo added a commit: rG51db2363243c: [DWP] Fix for Refactoring llvm-dwp in to a library.
Harbormaster completed remote builds in B115229: Diff 360331.Jul 20 2021, 7:42 PM

Revision Contents

PathSize
llvm/
tools/
llvm-dwp/
8 lines

Diff 360333

llvm/tools/llvm-dwp/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
AllTargetsAsmParsers AllTargetsAsmParsers
AllTargetsCodeGens AllTargetsCodeGens
AllTargetsDescs
AllTargetsInfos
AsmPrinter
DebugInfoDWARF
MC
Object
Support
Target
) )
add_llvm_tool(llvm-dwp add_llvm_tool(llvm-dwp
llvm-dwp.cpp llvm-dwp.cpp
DWP.cpp DWP.cpp
DWPError.cpp DWPError.cpp
DEPENDS DEPENDS
intrinsics_gen intrinsics_gen
) )
if(LLVM_INSTALL_BINUTILS_SYMLINKS) if(LLVM_INSTALL_BINUTILS_SYMLINKS)
add_llvm_tool_symlink(dwp llvm-dwp) add_llvm_tool_symlink(dwp llvm-dwp)
endif() endif()