This is an archive of the discontinued LLVM Phabricator instance.

Differential D106103

[test] Use double pound to denote comments.
ClosedPublic

Authored by drodriguez on Jul 15 2021, 2:53 PM.

Details

Reviewers
jhenderson
alexander-shaposhnikov
rupprecht
Commits
rG3c4023b225ac: [test] Use double pound to denote comments.
Summary

Use double pound at the start of the line to differentiate comments from
statements for Lit or FileCheck.

I will also use this small commit to check my commit access.

Diff Detail

Unit TestsFailed

TimeTest
2,660 msx64 debian > libarcher.barrier::barrier.c
2,830 msx64 debian > libarcher.critical::critical.c
2,810 msx64 debian > libarcher.races::critical-unrelated.c
3,130 msx64 debian > libarcher.races::lock-nested-unrelated.c
2,920 msx64 debian > libarcher.races::lock-unrelated.c
View Full Test Results (17 Failed)

Event Timeline

drodriguez created this revision.Jul 15 2021, 2:53 PM
Herald added a reviewer: alexander-shaposhnikov. · View Herald TranscriptJul 15 2021, 2:53 PM
Herald added a reviewer: rupprecht. · View Herald Transcript
drodriguez requested review of this revision.Jul 15 2021, 2:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2021, 2:53 PM
Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript
alexander-shaposhnikov accepted this revision.Jul 15 2021, 3:54 PM
This revision is now accepted and ready to land.Jul 15 2021, 3:54 PM
Harbormaster completed remote builds in B114361: Diff 359137.Jul 15 2021, 4:31 PM
This revision was landed with ongoing or failed builds.Jul 15 2021, 5:41 PM
Closed by commit rG3c4023b225ac: [test] Use double pound to denote comments. (authored by drodriguez). · Explain Why
This revision was automatically updated to reflect the committed changes.
drodriguez added a commit: rG3c4023b225ac: [test] Use double pound to denote comments..

Revision Contents

PathSize
llvm/
test/
tools/
llvm-objcopy/
6 lines

Diff 359137

llvm/test/tools/llvm-objcopy/grouped-options.test

# This test checks that both grouped and ungrouped options (-S -x and -Sx) ## This test checks that both grouped and ungrouped options (-S -x and -Sx)
# produce exactly the same result given the same input. ## produce exactly the same result given the same input.
#
# RUN: yaml2obj %s -o %t # RUN: yaml2obj %s -o %t
# RUN: llvm-strip -S -x -o %t-strip-separated %t # RUN: llvm-strip -S -x -o %t-strip-separated %t
# RUN: llvm-strip -Sx -o %t-strip-grouped %t # RUN: llvm-strip -Sx -o %t-strip-grouped %t
# RUN: cmp %t-strip-separated %t-strip-grouped # RUN: cmp %t-strip-separated %t-strip-grouped
# RUN: llvm-objcopy -S -x %t %t-objcopy-separated # RUN: llvm-objcopy -S -x %t %t-objcopy-separated
# RUN: llvm-objcopy -Sx %t %t-objcopy-grouped # RUN: llvm-objcopy -Sx %t %t-objcopy-grouped
# RUN: cmp %t-objcopy-separated %t-objcopy-grouped # RUN: cmp %t-objcopy-separated %t-objcopy-grouped
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines