Page MenuHomePhabricator

[NFC][MLIR][std] Clean up ArithmeticCastOps
ClosedPublic

Authored by GMNGeoffrey on Jul 13 2021, 12:59 PM.

Details

Summary

The documentation on these was out of sync with the implementation. Also
the declaration of inputs was repeated when it is already part of the
ArithmeticCastOp definition.

Diff Detail

Event Timeline

GMNGeoffrey created this revision.Jul 13 2021, 12:59 PM
GMNGeoffrey requested review of this revision.Jul 13 2021, 12:59 PM
GMNGeoffrey retitled this revision from [MLIR][std] Clean up ArithmeticCastOps to [NFC][MLIR][std] Clean up ArithmeticCastOps.Jul 13 2021, 1:00 PM
GMNGeoffrey added reviewers: mehdi_amini, rriddle.
rriddle accepted this revision.Jul 13 2021, 1:06 PM
rriddle added inline comments.
mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
52–54

It'd be nice to constrain these to something tighter than AnyType at some point.

This revision is now accepted and ready to land.Jul 13 2021, 1:06 PM
GMNGeoffrey added inline comments.Jul 13 2021, 1:24 PM
mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
52–54

The cast compatible functions do some additional type checking, but yeah this could still be narrower

This revision was automatically updated to reflect the committed changes.