This is an archive of the discontinued LLVM Phabricator instance.

[mlir][SCF] populateSCFStructuralTypeConversionsAndLegality WhileOp support
ClosedPublic

Authored by Hardcode84 on Jul 13 2021, 11:38 AM.

Diff Detail

Event Timeline

Hardcode84 created this revision.Jul 13 2021, 11:38 AM
Hardcode84 requested review of this revision.Jul 13 2021, 11:38 AM
ftynse accepted this revision.Jul 13 2021, 11:43 AM
ftynse added inline comments.
mlir/lib/Dialect/SCF/Transforms/StructuralTypeConversions.cpp
144

Nit: expand auto here please (should be a reference IIRC).

This revision is now accepted and ready to land.Jul 13 2021, 11:43 AM

Review comment and warning